PR to fix Retro 2.1 zarr headers bug and add zarr S3 endpoint to url list #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karnesh
changed the title
jameshalgren
approved these changes
May 16, 2024
Comment on lines
+500
to
+502
| if "ciroh-nwm-zarr-retrospective-data-copy" in urlbase_prefix: | ||
| url = url + ".json" | ||
| url = url.replace('.comp', '') |
There was a problem hiding this comment.
Would it make sense to use variables?
retro_url = "ciroh-nwm-zarr-retrospective-data-copy"
native_end = ".comp"
new_end = ".json"
This would potentially dovetail with a fix to this issue:
#9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the bug in the for loop which was looping over Individual characters of url string and updates base url list to include zarr s3 endpoint. This fixes #53 and #37.