Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade docker environment to Ubuntu 22.04 #28

Closed
wants to merge 3 commits into from
Closed

Conversation

alesparza
Copy link
Contributor

We will be doing this course wide

@alesparza alesparza linked an issue May 31, 2024 that may be closed by this pull request
@alesparza alesparza self-assigned this May 31, 2024
@alesparza alesparza linked an issue May 31, 2024 that may be closed by this pull request
@alesparza alesparza added the enhancement New feature or request label May 31, 2024
@alesparza alesparza requested a review from a team May 31, 2024 11:04
@alesparza alesparza marked this pull request as ready for review May 31, 2024 11:04
@alesparza
Copy link
Contributor Author

alesparza commented May 31, 2024

Please pull this from dockerhub using the tag ubuntu-22

docker pull cis548/docker-env:ubuntu-22
docker run -it -v ${pwd}:/home/cit595 --name ubuntu-test cis548/docker-env:ubuntu-22

This should automate pulling the image, naming it ubuntu-test, and starting it immediately.

Please check that clang and gcc work on some program and also run the test.sh script that is part of the dovker-env repository (clone repo first).

I did check for W11 ARM but I need someone with the amd architecture (Apple M1 chip) (two separate images)

@alesparza alesparza requested a review from nate285 May 31, 2024 11:08
@kneruda
Copy link

kneruda commented May 31, 2024 via email

@nate285
Copy link

nate285 commented May 31, 2024

Worked for me when I pulled it

@nate285
Copy link

nate285 commented May 31, 2024

And the test script worked as well. I'm on x86 ubuntu host machine

Copy link

@nate285 nate285 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we confirm it is working on arm I think it is all set

docker-setup.sh Outdated
apt-get install -y gcc clang-10 clang-format-10 make
update-alternatives --install /usr/bin/clang clang /usr/bin/clang-10 100
update-alternatives --install /usr/bin/clang-format clang-format /usr/bin/clang-format-10 100
apt-get install -y gcc clang-16 clang-format-16 make
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, I was wondering if we had to specify the clang version but when I try and update it, it already says it is on the newest version so I am assuming it does not matter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should just be clang and clang-format

@nate285
Copy link

nate285 commented May 31, 2024

Actually, is there a way to run the open CI stuff on this and ensure that all the tests work? It should not make a difference but it feels like it is probably a good idea.

@alesparza
Copy link
Contributor Author

Actually, is there a way to run the open CI stuff on this and ensure that all the tests work? It should not make a difference but it feels like it is probably a good idea.

We could set something up for CI. Not sure what we would do aside from maybe some basic compilations. There is a a test.sh that checks that everything installs correctly

@alesparza
Copy link
Contributor Author

The latest image as of right now is the one to verify

@alesparza alesparza closed this May 31, 2024
@alesparza alesparza deleted the ubuntu-22 branch May 31, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update to Ubuntu 22
3 participants