-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade docker environment to Ubuntu 22.04 #28
Conversation
Please pull this from dockerhub using the tag ubuntu-22
This should automate pulling the image, naming it ubuntu-test, and starting it immediately. Please check that clang and gcc work on some program and also run the I did check for W11 ARM but I need someone with the amd architecture (Apple M1 chip) (two separate images) |
I can check with an M1 tonight. Sent from my iPhoneOn 31 May 2024, at 4:09 AM, Antonio Esparza ***@***.***> wrote:
Please pull this from docerhub using the tag ubuntu-22
docker pull cis548/docker-env:ubuntu-22
docker run -it -v ${pwd}:/home/cit595 --name ubuntu-test cis548/docker-env:ubuntu-22
This should automate pulling the image, naming it ubuntu-test, and starting it immediately.
Please check that clang and gcc work on some program and also run the test.sh script that is part of the dovker-env repository (clone repo first).
I did check for W11 ARM but I need someone with the amd architecture (Apple M1 chip) (two separate images)
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: ***@***.***>
|
Worked for me when I pulled it |
And the test script worked as well. I'm on x86 ubuntu host machine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once we confirm it is working on arm I think it is all set
docker-setup.sh
Outdated
apt-get install -y gcc clang-10 clang-format-10 make | ||
update-alternatives --install /usr/bin/clang clang /usr/bin/clang-10 100 | ||
update-alternatives --install /usr/bin/clang-format clang-format /usr/bin/clang-format-10 100 | ||
apt-get install -y gcc clang-16 clang-format-16 make |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good, I was wondering if we had to specify the clang version but when I try and update it, it already says it is on the newest version so I am assuming it does not matter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should just be clang and clang-format
Actually, is there a way to run the open CI stuff on this and ensure that all the tests work? It should not make a difference but it feels like it is probably a good idea. |
We could set something up for CI. Not sure what we would do aside from maybe some basic compilations. There is a a test.sh that checks that everything installs correctly |
The latest image as of right now is the one to verify |
We will be doing this course wide