-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project 3: Yue Zhang #16
Open
YueZhang1027
wants to merge
26
commits into
CIS565-Fall-2023:main
Choose a base branch
from
YueZhang1027:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to do: BVH
todo: pbr to mix, fresnel in evaluation
TODO:full
buggy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two late day used. One late day for readme figure.
Core feature implemented.
CMakeList Change: I organize the code structure by seperate some features into single header. Also, I use some new files for other external functions, here is the change list:
Feedback: I really focus on this project and I almost missed another course's work (lol). For improvement, I do think several visual output figure with some sample scene or baseline running speed data will help debugging and comparision at first. There can be more decoupling on the original code structure.
Anyway, it's a project of infinite possiblity. I think I will restart it again after this semester (though with late day, the time is still limited for me to produce ideal visual effect.)