Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EASI-3505, EASI-4076] updating apollo/client and node v20 🎉 #1001

Closed
wants to merge 4 commits into from
Closed

[EASI-3505, EASI-4076] updating apollo/client and node v20 🎉 #1001

wants to merge 4 commits into from

Conversation

garyjzhao
Copy link
Contributor

@garyjzhao garyjzhao commented Mar 12, 2024 •
edited
Loading

EASI-3505, EASI-4076

Changes and Description

  • updated to node v20.11.1 LTS
  • remove apollo since it has been discontinued (end of life blog post)
  • updated apollo client to 3.9.6

How to test this change

  1. yarn install
  2. scripts/dev down && scripts/dev up
  3. Verify all things are well

PR Author Review Checklist

  • Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
  • Added or updated tests for backend resolvers or other functions as needed.
  • Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
  • Always make comments, even if it's minor, or if you don't understand why something was done.

@garyjzhao garyjzhao requested review from a team as code owners March 12, 2024 17:42
@garyjzhao garyjzhao requested review from patrickseguraoddball and removed request for a team March 12, 2024 17:42
ClayBenson94
ClayBenson94 requested changes Mar 12, 2024
View reviewed changes
Dockerfile.frontend Outdated Show resolved Hide resolved
@garyjzhao @ClayBenson94
Update Dockerfile.frontend
4c76e37 
Co-authored-by: Clay Benson <[email protected]>
@garyjzhao garyjzhao marked this pull request as draft March 12, 2024 18:01
@garyjzhao
Copy link
Contributor Author

Converting back to draft for reasons mentioned in slack thread
https://oddball.slack.com/archives/C059QQA3HK5/p1710266403072569?thread_ts=1710260051.830179&cid=C059QQA3HK5

@garyjzhao
Copy link
Contributor Author

Closing since updating to Node 20 is currently blocked by work stated above

@garyjzhao garyjzhao closed this Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClayBenson94 ClayBenson94 ClayBenson94 requested changes

@patrickseguraoddball patrickseguraoddball Awaiting requested review from patrickseguraoddball patrickseguraoddball was automatically assigned from CMSgov/mint-frontend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garyjzhao @ClayBenson94