Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EASI-4080] Convert Collaborators folder and NDA Queries #1002

Merged
merged 8 commits into from
Mar 20, 2024

Conversation

garyjzhao
Copy link
Contributor

@garyjzhao garyjzhao commented Mar 12, 2024

EASI-4080

Changes and Description

  • Convert GetIsCollaborator
  • Convert GetModelCollaborators
  • convert GetModelPlanCollaborator
  • Convert CreateModelPlanCollaborator
  • Convert CreateModelPlanCollaborator and DeleteModelPlanCollaborator
  • Convert UpdateNDA

How to test this change

  1. scripts/dev gql
  2. Check to see if updating NDA and adding/rendering collaborator works as expected

PR Author Review Checklist

  • Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
  • Added or updated tests for backend resolvers or other functions as needed.
  • Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
  • Always make comments, even if it's minor, or if you don't understand why something was done.

@garyjzhao garyjzhao requested a review from a team as a code owner March 12, 2024 19:18
@garyjzhao garyjzhao requested review from patrickseguraoddball and removed request for a team March 12, 2024 19:18
@garyjzhao garyjzhao changed the title [EASI-4076] Convert Collaborators folder and NDA Queries [EASI-4080] Convert Collaborators folder and NDA Queries Mar 13, 2024
Copy link
Contributor

@patrickseguraoddball patrickseguraoddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, thanks!

@garyjzhao garyjzhao merged commit 9e07d33 into main Mar 20, 2024
11 checks passed
@garyjzhao garyjzhao deleted the EASI-4076/query-conversion branch March 20, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants