[EASI-3945] Collaborator Added notification BE #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not (instead of inferrring from email service)
…ndNotification is false
…t has access to data loaders
…straint issue in unit tests
StevenWadeOddball
requested review from
OddTomBrooks and
garyjzhao
and removed request for
a team
StevenWadeOddball
changed the title
OddTomBrooks
approved these changes
Mar 15, 2024
StevenWadeOddball
merged commit 481c065
into
feature/EASI-3945_collaborator_added_notification
12 checks passed
StevenWadeOddball
deleted the
task/EASI-3945_collaborator_added_notification_be
branch
garyjzhao
pushed a commit
that referenced
this pull request
Apr 2, 2024
* feat: user notification user userIDRelation * feat: preliminary added as a collaboorator meta data type * feat: ActivityAddedAsCollaboratorCreate and unit test * feat: preliminary connection of added as collaborator notification * feat: add parameter to create collaborator to send a notification or not (instead of inferrring from email service) * feat: assert that a notification is made in the collaborator unit test * feat: add a unit test to assert a notification is not created when sendNotification is false * feat: new data loader WIP, collaborator sql files moved to SQL queries * feat: standardize collaborator method naming conventions * feat: plan collaborator get now utilizes dataloader. Correct wiring for dataloader * feat: unit test for planCollaborator by ID data loader * feat: utility error handling function for data loaders * chore: remove irrelevant comment * feat: update seeder to use config context instead of background, so it has access to data loaders * feat: update postman collection with example of new notification type * feat: move audit.change to be the last table truncated to address constraint issue in unit tests * feat: incorporate truncate logic from the daily digest notification branch * feat: add comments to the embedded SQL files for plan collaborator * chore: correct embed statement capitalization
4 tasks
garyjzhao
added a commit
that referenced
this pull request
Apr 5, 2024
* [EASI-3945] Collaborator Added notification BE (#1003) * feat: user notification user userIDRelation * feat: preliminary added as a collaboorator meta data type * feat: ActivityAddedAsCollaboratorCreate and unit test * feat: preliminary connection of added as collaborator notification * feat: add parameter to create collaborator to send a notification or not (instead of inferrring from email service) * feat: assert that a notification is made in the collaborator unit test * feat: add a unit test to assert a notification is not created when sendNotification is false * feat: new data loader WIP, collaborator sql files moved to SQL queries * feat: standardize collaborator method naming conventions * feat: plan collaborator get now utilizes dataloader. Correct wiring for dataloader * feat: unit test for planCollaborator by ID data loader * feat: utility error handling function for data loaders * chore: remove irrelevant comment * feat: update seeder to use config context instead of background, so it has access to data loaders * feat: update postman collection with example of new notification type * feat: move audit.change to be the last table truncated to address constraint issue in unit tests * feat: incorporate truncate logic from the daily digest notification branch * feat: add comments to the embedded SQL files for plan collaborator * chore: correct embed statement capitalization * feat: reintroduce functionality removed in merge * [EASI-3926] Frontend work for Add Collaborator Notification (#1031) * updated GetNotifications * streamline the query for add collab notification * drying up the click hander * move some functions around * DRYing up the functions * remove only in e2e test * add test to add collaborator notification --------- Co-authored-by: Steven Wade <[email protected]> Co-authored-by: Steven Wade <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EASI-3945
Changes and Description
How to test this change
If desired, update your notification preferences to turn off email for added as collaborator.
5. Repeat the above steps, but confirm you don't get an email for being added as a collaborator
6. Create a new model plan, ensure you don't get notified that you were added as a collaborator.
PR Author Review Checklist
PR Reviewer Guidelines