Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINT-3229]milestone category resolvers and milestone by ID #1542

Conversation

StevenWadeOddball
Copy link
Contributor

@StevenWadeOddball StevenWadeOddball commented Nov 27, 2024

MINT-3229

Description

  1. This implemented a resolver to return a new parent level MTOCategories type on an MTO milestone
    a. After syncing, we decided to rely on a parent level call and a dataloader to focus on simple maintainable code, instead of creating a more complicated dataloader that would return both records and deserialize.
  2. Syncing with the FE team, it was determined we should also be able to get a milestone by ID, so we don't have to call this category resolver when we are looking at all milestones for the model

How to test this change

Use the postman queries to

  1. Create an MTO milestone
  2. Get the MTO milestone by ID
  3. Verify the Categories information for the milestone.
    a. note a nil category will return uncategorized uncategorized

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@StevenWadeOddball StevenWadeOddball marked this pull request as ready for review November 27, 2024 20:10
@StevenWadeOddball StevenWadeOddball requested review from a team as code owners November 27, 2024 20:10
@StevenWadeOddball StevenWadeOddball requested review from OddTomBrooks, patrickseguraoddball and garyjzhao and removed request for a team November 27, 2024 20:10
Copy link
Collaborator

@ClayBenson94 ClayBenson94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few points of feedback and some suggestions -- mainly around TODO comments, other code comments, and function naming. Nothing too major, IMO!

pkg/graph/resolvers/mto_category.go Outdated Show resolved Hide resolved
pkg/graph/schema/types/mto_category.graphql Outdated Show resolved Hide resolved
pkg/graph/schema/types/mto_milestone.graphql Outdated Show resolved Hide resolved
pkg/models/mto_category.go Outdated Show resolved Hide resolved
pkg/models/mto_category.go Show resolved Hide resolved
pkg/storage/mto_milestone.go Outdated Show resolved Hide resolved
pkg/storage/mto_category.go Outdated Show resolved Hide resolved
@StevenWadeOddball
Copy link
Contributor Author

Thanks for the feedback Clay! Changes should be implemented :D

Copy link
Collaborator

@ClayBenson94 ClayBenson94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me! This should help unblock most of the FE for the edit milestone modal! 🚀

@StevenWadeOddball StevenWadeOddball merged commit a2d8b26 into feature/MINT-3175_mto Dec 3, 2024
10 checks passed
@StevenWadeOddball StevenWadeOddball deleted the MINT-3229/milestone_category_resolvers branch December 3, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants