-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MINT-3229]milestone category resolvers and milestone by ID #1542
[MINT-3229]milestone category resolvers and milestone by ID #1542
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a few points of feedback and some suggestions -- mainly around TODO
comments, other code comments, and function naming. Nothing too major, IMO!
Thanks for the feedback Clay! Changes should be implemented :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me! This should help unblock most of the FE for the edit milestone modal! 🚀
MINT-3229
Description
a. After syncing, we decided to rely on a parent level call and a dataloader to focus on simple maintainable code, instead of creating a more complicated dataloader that would return both records and deserialize.
How to test this change
Use the postman queries to
a. note a nil category will return uncategorized uncategorized
PR Author Checklist
PR Reviewer Guidelines