Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noref/fix solution types #1546

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

ClayBenson94
Copy link
Collaborator

@ClayBenson94 ClayBenson94 commented Dec 2, 2024

NOREF

Description

  • Updates SQL types and migrations to reference CONTRACTOR as a SolutionType instead of CONTRACT (which appeared to just be a typo/mismatch from SQL to GQL)

How to test this change

  1. Ensure that adding a custom solution through postman with the CONTRACTOR type works as expected

Before

Below is a screenshot of the failure you'll see outside this branch, courtesy of @garyjzhao
image

After

image

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@ClayBenson94 ClayBenson94 changed the base branch from main to feature/MINT-3175_mto December 2, 2024 19:26
@ClayBenson94 ClayBenson94 marked this pull request as ready for review December 2, 2024 19:26
@ClayBenson94 ClayBenson94 requested a review from a team as a code owner December 2, 2024 19:26
@ClayBenson94 ClayBenson94 requested review from StevenWadeOddball, garyjzhao and OddTomBrooks and removed request for a team and StevenWadeOddball December 2, 2024 19:26
Copy link
Contributor

@garyjzhao garyjzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClayBenson94 ClayBenson94 merged commit f84558b into feature/MINT-3175_mto Dec 2, 2024
11 checks passed
@ClayBenson94 ClayBenson94 deleted the NOREF/fix_solution_types branch December 2, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants