Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINT-3211] Custom Solutions Form Modal #1547

Merged

Conversation

garyjzhao
Copy link
Contributor

@garyjzhao garyjzhao commented Dec 2, 2024

MINT-3211

Description

  • Add MTOMilestoneTranslation and all the CH stuff
  • Add SolutionForm component, testing file, gql mutation, translations

How to test this change

  1. Navigate to MTO home page
  2. Click Add custom solution button
  3. Verify that modal matches figma and functions as expected
  4. Verify error and success messages

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@garyjzhao garyjzhao marked this pull request as ready for review December 2, 2024 20:17
@garyjzhao garyjzhao requested review from a team as code owners December 2, 2024 20:17
@garyjzhao garyjzhao requested review from OddTomBrooks and patrickseguraoddball and removed request for a team December 2, 2024 20:17
Copy link
Contributor

@patrickseguraoddball patrickseguraoddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, nice Gary :)

@garyjzhao garyjzhao merged commit 42ece16 into feature/MINT-3175_mto Dec 3, 2024
11 checks passed
@garyjzhao garyjzhao deleted the MINT-3211/custom-solutions-form-modal branch December 3, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants