[NOREF] Initial MTO Milestone resolver tests #1548
Conversation
ClayBenson94
requested review from
StevenWadeOddball,
garyjzhao and
OddTomBrooks
and removed request for
a team
| suite.NoError(err) | ||
| suite.Len(categories, 2) // 1 new category (Operations) + Uncategorized | ||
|
|
||
| operationsCategory, found := lo.Find(categories, func(item *models.MTOCategory) bool { |
There was a problem hiding this comment.
Now that the resolver is merged in, I might suggest calling MTOCategoriesGetByID to verify the category and subcategory. I do like that this is validating the category creation though!
Also fine to keep this the way it is since you are validating all categories for the MTO!
There was a problem hiding this comment.
I'll see if I can simplify any of this using this new resolver :)
There was a problem hiding this comment.
I think I'm just going to add a comment for a potential change here -- I had a bit of trouble implementing MTOCategoriesGetByID because I still ended up wanting to fetch the total list of categories/subcategories to ensure the proper number of categories existed post-creation (which MTOCategoriesGetByID doesn't necessarily validate)
| _, foundInternalFunctions := lo.Find(operationsSubCategories, func(item *models.MTOSubcategory) bool { | ||
| return item != nil && item.Name == "Internal functions" | ||
| }) | ||
| suite.True(foundInternalFunctions) |
There was a problem hiding this comment.
Would it be useful to validate a case where the subcategory already exists? Or that it will make a new category if you rename a category?
There was a problem hiding this comment.
I might add some TODO comments to consider those cases! I didn't do those right away since I wanted to just kickstart these tests with the happy paths, but I agree these would be good test cases!
|
Waiting to merge this until #1541 is in, since there'll be a lot of conflicts on this |
NOREF
Description
Important
This PR is purposefully not exhaustive - I just wanted to get some tests written for this resolver file so we had somewhere to write other tests, and to validate some of the more complex logic (like Common Milestones creating categories upon their instantiation)
How to test this change
pkg/graph/resolvers/mto_milestone_test.goand make sure they all make sense and are readablePR Author Checklist
PR Reviewer Guidelines