Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOREF]Constrain mto solution poc fields #1550

Conversation

StevenWadeOddball
Copy link
Contributor

@StevenWadeOddball StevenWadeOddball commented Dec 3, 2024

NOREF

Description

  1. POC email and POC name are now not editable if you make a custom solution
  2. Milestone and solutions sourced from common options now update correctly, and don't attempt to set name and type

How to test this change

  1. Create a solution from a common solution
  2. attempt to edit the poc info.
  3. Confirm the action fails.
  4. Edit other information. Confirm it passes
  5. Confirm you can update a milestone made from the common milestone library.

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@StevenWadeOddball StevenWadeOddball requested a review from a team as a code owner December 3, 2024 20:13
@StevenWadeOddball StevenWadeOddball requested review from OddTomBrooks and ClayBenson94 and removed request for a team December 3, 2024 20:13
Copy link
Collaborator

@ClayBenson94 ClayBenson94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving! Had some suggestions about potentially improved logging, and maybe a suggestion for the SQL constraint, but nothing that should stop this from merging as-is if you want!

migrations/V186__Add_MTO_Solution.sql Show resolved Hide resolved
pkg/graph/resolvers/mto_milestone.go Show resolved Hide resolved
pkg/graph/resolvers/mto_solution.go Show resolved Hide resolved
Copy link
Contributor

@OddTomBrooks OddTomBrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no significant feedback. The changes are succinct and self-evident.

@StevenWadeOddball StevenWadeOddball merged commit b533ff4 into feature/MINT-3175_mto Dec 4, 2024
10 checks passed
@StevenWadeOddball StevenWadeOddball deleted the NOREF/constrain_mto_solution_poc_fields branch December 4, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants