Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINT-3230] About this milestone panel #1551

Conversation

patrickseguraoddball
Copy link
Contributor

MINT-3230

Description

  • Added <MilestonePanel />
  • Added <SolutionCard />
  • Tweaked styles and functionality of solution panels
  • Added link to render/add custom milestone form
  • Added unit tests

How to test this change

  1. Create model plan and navigate to MTO -> milestone library
  2. Click on any 'About this milestone'
  3. Verify figma matches
  4. Verify responsiveness
  5. Verify solution panels work as expected/overlay on top of milestone
  6. Verify the add custom milestone works

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@patrickseguraoddball patrickseguraoddball requested a review from a team as a code owner December 4, 2024 16:55
@patrickseguraoddball patrickseguraoddball requested review from garyjzhao and removed request for a team and garyjzhao December 4, 2024 16:55
@patrickseguraoddball patrickseguraoddball marked this pull request as draft December 4, 2024 17:17
@patrickseguraoddball patrickseguraoddball marked this pull request as ready for review December 4, 2024 19:21
Copy link
Contributor

@garyjzhao garyjzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

things are working as described. good work!

@patrickseguraoddball patrickseguraoddball merged commit 97c01e6 into feature/MINT-3175_mto Dec 6, 2024
11 checks passed
@patrickseguraoddball patrickseguraoddball deleted the MINT-3230/about-this-milestone-panel branch December 6, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants