Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINT-3215] Suggested mto milestones #1555

Merged

Conversation

StevenWadeOddball
Copy link
Contributor

@StevenWadeOddball StevenWadeOddball commented Dec 5, 2024

MINT-3215

Description

  • new table for suggested milestones
  • Various migrations that
    • determine if a milestone should be suggested based on table
    • determine if a section should be suggested based on model plan id
    • enable trigger on task list sections
    • suggest milestones for all legacy data

How to test this change

  1. To test the migration of legacy data, comment out migration V199
  2. Bring up the app and use the postman collection to update plan participants and providers PlanParticipantsAndProvidersUpdate And make 6 suggested milestones
  3. Run the code of Migration 197 in the sql explorer of your choice to confirm that 6 suggested milestones are created

Alternatively, if you don't comment out V199, running that query will automatically create 6 suggested milestones. You can verify by

  1. Looking in SQL
  2. Querying common milestones, and verifying that they are suggested
APP_SUPPORT_CON
VET_PROVIDERS_FOR_PROGRAM_INTEGRITY
MANAGE_PROV_OVERLAP
RECRUIT_PARTICIPANTS
REV_SCORE_APP
COMM_W_PART

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@StevenWadeOddball StevenWadeOddball marked this pull request as ready for review December 6, 2024 15:40
@StevenWadeOddball StevenWadeOddball requested review from a team as code owners December 6, 2024 15:40
@StevenWadeOddball StevenWadeOddball requested review from OddTomBrooks, patrickseguraoddball, garyjzhao and ClayBenson94 and removed request for a team December 6, 2024 15:40
Copy link
Collaborator

@ClayBenson94 ClayBenson94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and seem to work as expected. Appreciate the comments on the SQL migrations

@StevenWadeOddball StevenWadeOddball merged commit ee10c3d into feature/MINT-3175_mto Dec 9, 2024
10 checks passed
@StevenWadeOddball StevenWadeOddball deleted the MINT-3215/recommended_mto_milestone branch December 9, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants