Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOREF] Show MTO matrix if started #1556

Merged

Conversation

patrickseguraoddball
Copy link
Contributor

NOREF

Description

Previously MTO matrix was hidden if there were no milestones added. The util in this PR will check if any categories or subcategories have been created as criteria for rendering the MTO matrix - even in the absence of any milestones. This util will also not count Uncategorized as categories/subcategories.

Additionally added a custom apollo cache key and removed toggle icon if no children present

Caution

We have not yet hooked up a refetch on the form mutations, so you will need to refresh or force rerender in the app to see changes take effect.

How to test this change

  1. Create a model plan and go to matrix
  2. Verify empty state
  3. Added a category and refresh
  4. Verify matrix renders
  5. Repeat but this time add a milestone
  6. Verify matrix renders

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@patrickseguraoddball patrickseguraoddball requested a review from a team as a code owner December 5, 2024 15:52
@patrickseguraoddball patrickseguraoddball requested review from garyjzhao and ClayBenson94 and removed request for a team December 5, 2024 15:52
@ClayBenson94 ClayBenson94 mentioned this pull request Dec 5, 2024
4 tasks
@ClayBenson94 ClayBenson94 requested a review from a team as a code owner December 6, 2024 12:55
@ClayBenson94 ClayBenson94 requested review from StevenWadeOddball and removed request for a team and StevenWadeOddball December 6, 2024 12:55
Copy link
Collaborator

@ClayBenson94 ClayBenson94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected! Thanks @patrickseguraoddball!

image

Copy link
Contributor

@garyjzhao garyjzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Category and Milestones are rendering on the table

50924

@patrickseguraoddball patrickseguraoddball merged commit 582091e into feature/MINT-3175_mto Dec 6, 2024
10 checks passed
@patrickseguraoddball patrickseguraoddball deleted the NOREF/show-mto-matrix-if-started branch December 6, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants