Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINT-3235] Get milestones and solutions by relation loaders and helper methods #1563

Conversation

StevenWadeOddball
Copy link
Contributor

@StevenWadeOddball StevenWadeOddball commented Dec 10, 2024

MINT-3235

Description

  1. This is a follow up PR to [MINT-3235] Get milestones and solutions by relation loaders #1557
  2. Unit tests for getting solutions and milestones
  3. Updated mapping function to allow a custom maptype

How to test this change

  1. Use postman to create a common milestone with common solutions
  2. Use the query to return milestones and their solutions,
    a. ensure that the new common solutions are returned
    b. ensure the nested milestone returned is that milestone

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@StevenWadeOddball StevenWadeOddball marked this pull request as ready for review December 10, 2024 16:41
@StevenWadeOddball StevenWadeOddball requested review from a team as code owners December 10, 2024 16:41
@StevenWadeOddball StevenWadeOddball requested review from OddTomBrooks, garyjzhao, patrickseguraoddball and ClayBenson94 and removed request for a team December 10, 2024 16:41
Copy link
Contributor

@OddTomBrooks OddTomBrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no feedback on the PR and functional testing was successful

@StevenWadeOddball StevenWadeOddball merged commit f9bd06b into feature/MINT-3175_mto Dec 11, 2024
10 checks passed
@StevenWadeOddball StevenWadeOddball deleted the task/MINT-3235_get_linked_milestones_and_solutions branch December 11, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants