Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOREF] correct casing to sentence case for standard categories #1564

Merged

Conversation

StevenWadeOddball
Copy link
Contributor

@StevenWadeOddball StevenWadeOddball commented Dec 10, 2024

Description

Standard category name casing didn't match the category names configured for a common milestone. This standardizes the casing so duplicate categories aren't created

Also, I added a collation to the name column to enforce case insensitivity. See this pgres documentation

How to test this change

  1. Create standard categories
  2. Create a common milestone that uses the standard category
  3. ensure that a duplicate category is not created.

Test the case insensitive table constraint

  1. Make a category
  2. Make another category with exactly the same name, but different casing. Ensure that this errors

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@StevenWadeOddball StevenWadeOddball requested a review from a team as a code owner December 10, 2024 18:20
@StevenWadeOddball StevenWadeOddball requested review from OddTomBrooks, ClayBenson94 and patrickseguraoddball and removed request for a team and OddTomBrooks December 10, 2024 18:20
@StevenWadeOddball StevenWadeOddball merged commit baaa41e into feature/MINT-3175_mto Dec 11, 2024
10 checks passed
@StevenWadeOddball StevenWadeOddball deleted the NOREF/preset_category_casing_fix branch December 11, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants