[MINT-3242] Linking Action Menu Add Milestone & Add Sub-Category to Respective Modals && pass down prepopulated categories #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…theMatrix row dropdown
… reset after form is submitted
garyjzhao
requested review from
patrickseguraoddball
and removed request for
a team
garyjzhao
commented
Dec 12, 2024
Comment on lines
-210
to
+228
| {/* If column is the Actions column, render <ActionMenu /> with custom buttons that updates data state for reordering */} | ||
| {column.accessor === 'actions' ? ( | ||
| <ActionMenu | ||
| rowType={rowType} | ||
| MoveUp={ | ||
| <Button | ||
| type="button" | ||
| disabled={ | ||
| currentIndex === 0 || | ||
| currentIndex === (rowLength || 0) - 1 | ||
| } | ||
| onClick={e => { | ||
| e.stopPropagation(); | ||
| setRearrangedData( | ||
| moveRow( | ||
| setIndexes, | ||
| moveRowDirection(-1), | ||
| rowType, | ||
| sortedData, | ||
| updateOrder, | ||
| setError | ||
| ) | ||
| ); | ||
| }} | ||
| onKeyPress={e => { | ||
| e.stopPropagation(); | ||
| }} | ||
| className="share-export-modal__menu-item padding-y-1 padding-x-2 action-menu-item" | ||
| unstyled | ||
| > | ||
| {t( | ||
| `modelToOperationsMisc:table.menu.${rowType === 'category' ? 'moveCategoryUp' : 'moveSubCategoryUp'}` | ||
| )} | ||
| </Button> | ||
| } | ||
| MoveDown={ | ||
| <Button | ||
| type="button" | ||
| disabled={ | ||
| currentIndex === (rowLength || 0) - 1 || | ||
| currentIndex === (rowLength || 0) - 2 | ||
| } | ||
| onClick={e => { | ||
| e.stopPropagation(); | ||
| setRearrangedData( | ||
| moveRow( | ||
| setIndexes, | ||
| moveRowDirection(1), | ||
| rowType, | ||
| sortedData, | ||
| updateOrder, | ||
| setError | ||
| ) | ||
| ); | ||
| }} | ||
| onKeyPress={e => { | ||
| e.stopPropagation(); | ||
| }} | ||
| className="share-export-modal__menu-item padding-y-1 padding-x-2 action-menu-item" | ||
| unstyled | ||
| > | ||
| {t( | ||
| `modelToOperationsMisc:table.menu.${rowType === 'category' ? 'moveCategoryDown' : 'moveSubCategoryDown'}` | ||
| )} | ||
| </Button> | ||
| } | ||
| /> | ||
| ) : ( | ||
| <> | ||
| {RenderCell ? ( | ||
| <RenderCell row={row} rowType={rowType} expanded={expanded} /> | ||
| ) : ( | ||
| row[column.accessor as keyof MilestoneType] | ||
| )} | ||
| </> | ||
| )} | ||
| </td> | ||
| ); | ||
| })} | ||
| </> | ||
| ); | ||
| const RenderCells = ({ | ||
| row, | ||
| rowType, | ||
| expanded, | ||
| currentIndex, | ||
| rowLength, | ||
| categoryID, | ||
| subCategoryID, | ||
| categoryIndex | ||
| }: { | ||
| row: RowType; | ||
| rowType: MTORowType; | ||
| expanded: boolean; | ||
| currentIndex: number; | ||
| rowLength: number; | ||
| categoryID?: string; | ||
| subCategoryID?: string; | ||
| categoryIndex?: number; | ||
| }) => { |
There was a problem hiding this comment.
Converted renderCells function to a functional component to aid in no longer needing to remember the function parameter order when calling the function and not needing to write out undefined for optional parameters.
i.e.
{renderCells(row, rowType, false, 0, 0, undefined, undefined, undefined)}vs
<RenderCells
row={row}
rowType={rowType}
expanded={false}
currentIndex={0}
rowLength={0}
// categoryID, subCategoryID, categoryIndex omitted
/>It was also easier for me to keep things in my head when developing 😂
patrickseguraoddball
requested changes
Dec 13, 2024
Comment on lines
+40
to
+43
|
|
||
| if (fireAfterOpening) { | ||
| fireAfterOpening(); | ||
| } |
There was a problem hiding this comment.
I'm a little unsure of the fireAfterOpening is created, would just calling the function needed on close work? Normally we run the resets when modals close, rather than after opening. Maybe we can sync to talk through ti
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MINT-3242
Description
fireAfterOpeningprop to Modal component to allow custom function to fire upon modal openingMTOModalContextto allow for easier state management and prevent prop drilling forMTOTableandMTOTableActionsAddCustomCategoryFormandAddCustomMilestoneFormto take in prepopulated categoryID and optional subcategoryIDHow to test this change
a.
Add model milestoneon parent category to pop up milestone modal with primary category pre-populatedb.
Add sub-categoryon parent category to pop up custom category modal and with things pre-populatedc.
Add model milestoneon subcategory to pop up milestone modal with primary category AND SUBCATEGORY pre-populatedPR Author Checklist
PR Reviewer Guidelines