Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Easi 3925/in app notifications #954

Merged
merged 73 commits into from
Feb 23, 2024
Merged

Easi 3925/in app notifications #954

merged 73 commits into from
Feb 23, 2024

Conversation

StevenWadeOddball
Copy link
Contributor

@StevenWadeOddball StevenWadeOddball commented Feb 14, 2024 •
edited
Loading

Easi 3925

Changes and Description

  • Base Implementation for
  • Activity
  • User Notification
  • User Notification Preference

Activity implemented for when a user is Tagged in a Discussion, or when Tagged in a discussion reply

How to test this change

  1. Bring up the application.

  2. Use either the front end or the backend to create a model plan and a discussion and discussion reply where you are tagged.

  3. verify that you receive a notification (use the postman collection), and an email that you were tagged

  4. Update your notification preference using postman to not receive an email

  5. Tag yourself again.

  6. Confirm that you got a new notification, but not an email

  7. Do the same for discussion replies

Unit Tests

  1. Confirm all unit tests pass as expected
  2. Confirm there isn't any missing coverage

Migration

  1. Confirm that the migration adds a user preference for all existing user accounts ( can verify with the system accounts)

PR Author Review Checklist

  • Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
  • Added or updated tests for backend resolvers or other functions as needed.
  • Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
  • Always make comments, even if it's minor, or if you don't understand why something was done.

@StevenWadeOddball
feat: pull in sqlutils changes from POC
00be44d
@StevenWadeOddball
feat: pull in sqlqueries from poc branch
9432183
@StevenWadeOddball
feat: pull data migration from poc branch
66abf97
@StevenWadeOddball
feat: gql changes from POC branch
e79e424
@StevenWadeOddball
feat: pull in notification_preferences file from poc branch
5469fcb
@StevenWadeOddball
feat: pull in notification package as is from POC branch. It will be …
a621993 
…refactored
@StevenWadeOddball
feat: working prototype from POC to refactor
030f8a2
@StevenWadeOddball
feat: correct spelling errors in comments
6e21a62
@StevenWadeOddball
feat: add some more notification types
4f53760
@StevenWadeOddball
feat: first pass at creating an activity and tag for taggged users in…
508dba3 
… a discussion. More work to follow to only create one activity
@StevenWadeOddball
feat: tagged plan discussion now creates one activity, and a notifica…
6acb1d7 
…tion for each tagged user
@StevenWadeOddball
feat: expand the notification preference table
ad5999f
@StevenWadeOddball
feat: user notification preferences SQL
be3d3e9
@StevenWadeOddball
feat: user notification preferences storage methods
7aed347
@StevenWadeOddball
feat: connect notifiation preferences resolver to GQL
272ae81
@StevenWadeOddball
feat: first pass at updateing userNotification Preferences
b8b59f9
@StevenWadeOddball
feat: create a user notification preferences object whenever you crea…
8302844 
…te a user account
@StevenWadeOddball
feat: set notification preferences to true by default
0583e0c
@StevenWadeOddball
feat: fetchable user notification preferences object in the schema
408ebdb
@StevenWadeOddball
chore: correct syntax in comment issue in sql statement. : incorrectl…
905cd50 
…y procesed as a named param
@StevenWadeOddball
feat: get notification preference before creating notification. add i…
dcb8ede 
…s archived, and expect email notification column to notification
@StevenWadeOddball
feat: first pass at discussion reply activity and notifications
f054508
@StevenWadeOddball
feat: postman collection for notifications
1f41e30
@StevenWadeOddball StevenWadeOddball marked this pull request as ready for review February 21, 2024 23:05
@StevenWadeOddball StevenWadeOddball requested review from a team as code owners February 21, 2024 23:05
@StevenWadeOddball StevenWadeOddball requested review from OddTomBrooks, garyjzhao, ClayBenson94 and patrickseguraoddball and removed request for a team February 21, 2024 23:05
@patrickseguraoddball
Copy link
Contributor

Followed all the testing instructions and works beautifully! Going to trying to explore any edge cases I can think of

@StevenWadeOddball
Merge branch 'main' into EASI-3925/in_app_notifications
16af931 
# Conflicts:
#	pkg/graph/generated/generated.go
#	pkg/graph/resolvers/schema.resolvers.go
#	pkg/graph/schema/schema.graphql
OddTomBrooks
OddTomBrooks previously approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@OddTomBrooks OddTomBrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some ghost code to potentially clean up but overall A++

@StevenWadeOddball StevenWadeOddball merged commit c02853c into main Feb 23, 2024
11 checks passed
@StevenWadeOddball StevenWadeOddball deleted the EASI-3925/in_app_notifications branch February 23, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClayBenson94 ClayBenson94 ClayBenson94 left review comments

@OddTomBrooks OddTomBrooks OddTomBrooks approved these changes

@garyjzhao garyjzhao Awaiting requested review from garyjzhao garyjzhao was automatically assigned from CMSgov/mint-frontend

@patrickseguraoddball patrickseguraoddball Awaiting requested review from patrickseguraoddball

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StevenWadeOddball @patrickseguraoddball @ClayBenson94 @OddTomBrooks