Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EASI-3934] Dependency Updates -- Round 1 #955

Merged
merged 21 commits into from
Feb 20, 2024

Conversation

garyjzhao
Copy link
Contributor

@garyjzhao garyjzhao commented Feb 15, 2024

EASI-3934

Changes and Description

  • Updated the following to the latest version as of 2/16:
    • @apollo/client
    • @babel/core
    • @babel/preset-env
    • @types/react-table
    • classnames
    • cypress
    • detect-browser
    • json2csv
    • okta/okta-react
    • okta/okta-sigin-widget
    • react-ga4
    • react-modal
    • react-paginate
    • react-select
    • react-to-print
    • redux-devtools-extension
    • sass
    • storybook
    • wait-on
    • yup
  • Removed the following:
  • Ran npx browserslist@latest --update-db to update the browserlist

How to test this change

  1. yarn install
  2. Bring up app
  3. Navigate through app to see if anything breaks
  4. Try out the CSV
  5. Try out storybook

PR Author Review Checklist

  • Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
  • Added or updated tests for backend resolvers or other functions as needed.
  • Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
  • Always make comments, even if it's minor, or if you don't understand why something was done.

@garyjzhao garyjzhao changed the title [EASI-3934] Dependency Updates [EASI-3934] Dependency Updates -- Round 1 Feb 15, 2024
@garyjzhao garyjzhao marked this pull request as ready for review February 15, 2024 15:35
@garyjzhao garyjzhao requested a review from a team as a code owner February 15, 2024 15:35
@garyjzhao garyjzhao requested review from patrickseguraoddball and removed request for a team February 15, 2024 15:35
@garyjzhao garyjzhao force-pushed the EASI-3934/dependency-updates-1 branch from 478a375 to 831bbef Compare February 15, 2024 21:43
@garyjzhao garyjzhao marked this pull request as draft February 15, 2024 21:44
@garyjzhao garyjzhao marked this pull request as ready for review February 16, 2024 14:52
Copy link
Contributor

@patrickseguraoddball patrickseguraoddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few Storybook stories that are not working. We probably want to figure out what broke in them as it could affect the actual components. It may be just something within Storybook, but work examining/fixing. I verified that these are working as intended on Main

Screenshot 2024-02-19 at 8 17 50 AM

Copy link
Contributor

@patrickseguraoddball patrickseguraoddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working! What I was seeing earlier doesn't seem to be happening in storybook now

@garyjzhao garyjzhao merged commit 12b2808 into main Feb 20, 2024
11 checks passed
@garyjzhao garyjzhao deleted the EASI-3934/dependency-updates-1 branch February 20, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants