[task: EASI-3923] General Characteristics And Basics Readonly Updates #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickseguraoddball
requested review from
garyjzhao
and removed request for
a team
patrickseguraoddball
changed the title
patrickseguraoddball
merged commit 1f5945f
into
feature/EASI-3923_conditional-relation-translation-updates
10 checks passed
patrickseguraoddball
deleted the
task/EASI-3923_model_basics_and_gen_char_updates
branch
4 tasks
patrickseguraoddball
added a commit
that referenced
this pull request
Feb 26, 2024
* [task: EASI-3923] Create base support for conditional relationships (#956) * Defined new type for parent and child relations * Added readonly component and util for rendering unneeded questions * Fixed css * Rework readonlysection * Added comments, cleaned up code/logic * Tweaked readonly section logic, added more pAndP renders * Adding more pAndP readonly * Adjuested the conditional logic, added comments * Fixed related question condition * Made readonly render completely dynamic * Added comments for clarity * Added comments for clarity * Added comments for clarity * Renamed some types * Relocated util, adjusted alert render * Gave childRelation its own type * updated plural toggle text * Added csv support for conditional field and unit test * Extracted reusable readonly body, implemented into pAndP * Updated snapshot * Changed order of generaic to match * Added unit test for new utils * Added comments * Converted string model filter values to ModelViewFilter enum in translations * Updated csv to use new filter group enum map * Updated snaps * Removed unneeded evaluationMethod type * Changed prop type to use enw filter group enum map * Updated participants question per figma, updated unit tests * Added additional type to capture ability to add readonly header at start of page * Reformatted comments * Fixed type on transkation key * Added partial type to some properties * Trying out alt method for parent child relation * Refactored conditonal * Removed unneeded generic for certain type * Added comment, addressed linting * Renamed translation type properties * Updated snaps * Fixed incorrect type assignment * Added new util for comparing closure, added unit test * Updated how adjacent fields are defined and rendered * Updated snaps * Refactored a conditional * Refactored logic in closure comparison * [task: EASI-3923] General Characteristics And Basics Readonly Updates (#959) * Began work on general characteristics * Added support for nested children list render * Added support for nested lists underneath radio selections * Refactored some params * Updated snaps * Changed prop type for listItemValues * Added support for model basics * Added class to not print tooltips in pdf * Updated snaps and unit test * Updated snaps * Added missing care config, updated snap * Updated snaps and added missing config * [task: EASI-3923] Beneficiaries and Ops Eval and Learning Readonly Updates (#961) * Began work on general characteristics * Added support for nested children list render * Added support for nested lists underneath radio selections * Refactored some params * Updated snaps * Changed prop type for listItemValues * Added support for model basics * Added class to not print tooltips in pdf * Updated snaps and unit test * Updated snaps * Added beneficiary and ops updates to readonly * Updated snaps * Updated snap * Updated snaps and added missing config * Fixed issue with list other items not rendering * [task: EASI-3923] Payments Readonly Updates and Refactor (#968) * Began work on general characteristics * Added support for nested children list render * Added support for nested lists underneath radio selections * Refactored some params * Updated snaps * Changed prop type for listItemValues * Added support for model basics * Added class to not print tooltips in pdf * Updated snaps and unit test * Updated snaps * Added beneficiary and ops updates to readonly * Updated snaps * Updated snap * Updated snaps and added missing config * Added additional support for unneeded question check * Fixed issue with list other items not rendering * Reordered type extension * Refactored readonly code * Refactored readonly code further * Added a few comments * Wrapped up payments readonly implementation * Removed old readonly files, rename new * Removed unneeded import * Refactored related question component * Renamed some utils * Fixed na text translations * Added loading render for readonyl data * Adjust no info text render * Fixed child radio list render, updated snaspshots * Audited filter views, added expanded configuration options * Refactored filtergroup type, fixed some readonly configs * Added comments for clarity * Updated snaps * Updated snaps * Updated unit test * Fixed hidden condition logic, ensured value is array before looping * Updated snaps, fix unit tests/function * Updated unit test * [task: EASI-3923] Toggle conditions on pdf export (#971) * Began work on general characteristics * Added support for nested children list render * Added support for nested lists underneath radio selections * Refactored some params * Updated snaps * Changed prop type for listItemValues * Added support for model basics * Added class to not print tooltips in pdf * Updated snaps and unit test * Updated snaps * Added beneficiary and ops updates to readonly * Updated snaps * Updated snap * Updated snaps and added missing config * Added additional support for unneeded question check * Fixed issue with list other items not rendering * Reordered type extension * Refactored readonly code * Refactored readonly code further * Added a few comments * Wrapped up payments readonly implementation * Removed old readonly files, rename new * Removed unneeded import * Refactored related question component * Renamed some utils * Fixed na text translations * Added loading render for readonyl data * Adjust no info text render * Fixed child radio list render, updated snaspshots * Audited filter views, added expanded configuration options * Refactored filtergroup type, fixed some readonly configs * Added comments for clarity * Updated snaps * Updated snaps * Updated unit test * Added context wrapper to manage toggle state for all readony * Added ability to revert to original state after pdf * Replace instance of context wrapper directly into read view * Fixed hidden condition logic, ensured value is array before looping * Added no print class to alert toggle * Updated snaps, fix unit tests/function * Updated unit test * Updated snaps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EASI-3923
Figma
Changes and Description
How to test this change
Verify General Characteristics readonly matches Figma
Verify Model Basics readonly behaves exactly as it did before (No figma changes)
PR Author Review Checklist
PR Reviewer Guidelines