Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EASI-3919] - Notification settings #980

Merged
merged 11 commits into from
Feb 29, 2024

Conversation

patrickseguraoddball
Copy link
Contributor

@patrickseguraoddball patrickseguraoddball commented Feb 27, 2024

EASI-3919

Changes and Description

  • Added route for notifications setting
  • Added query and mutation for fetching and saving
  • Added form components
  • Error state
  • LD Flag around route
  • Unit tests

taggedInDiscussionReply is not currently being rendered in the UI, but it's data should always match taggedInDiscussion for now.

How to test this change

  • Navigate to /notifications/settings
  • Verify all in-app notifications are always disabled
  • Verify form persists
  • Verify that taggedInDiscussionReply data always mirrors taggedInDiscussion when fetching/updating

PR Author Review Checklist

  • Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
  • Added or updated tests for backend resolvers or other functions as needed.
  • Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
  • Always make comments, even if it's minor, or if you don't understand why something was done.

@patrickseguraoddball patrickseguraoddball requested a review from a team as a code owner February 27, 2024 22:55
@patrickseguraoddball patrickseguraoddball requested review from garyjzhao and removed request for a team February 27, 2024 22:55
Copy link
Contributor

@garyjzhao garyjzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks GRRReat!

@patrickseguraoddball patrickseguraoddball merged commit 4185ba8 into main Feb 29, 2024
11 checks passed
@patrickseguraoddball patrickseguraoddball deleted the EASI-3919/notification-settings branch February 29, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants