Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EASI-3902] Operational solutions filter view #982

Merged
merged 8 commits into from
Feb 29, 2024

Conversation

patrickseguraoddball
Copy link
Contributor

@patrickseguraoddball patrickseguraoddball commented Feb 28, 2024

EASI-3902

Screenshot 2024-02-28 at 2 47 22 PM

Changes and Description

  • Added operational solutions table to relevant filter views
  • Added map of solutions to filter views
  • Deprecated old/unneeded filter view map
  • Added util to gather all fields from translations for a specified filter view
  • Add alert component to render unanswered solutions on op solutions filter view
  • Added/updated unit tests

How to test this change

  • Trigger some operational needs by answering questions in task list
  • Verify solutions rendered in the table on each filter view match Figma
  • Verify any unselected solutions for that filter view are rendered in the alert

PR Author Review Checklist

  • Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
  • Added or updated tests for backend resolvers or other functions as needed.
  • Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
  • Always make comments, even if it's minor, or if you don't understand why something was done.

@patrickseguraoddball patrickseguraoddball marked this pull request as ready for review February 28, 2024 20:56
@patrickseguraoddball patrickseguraoddball requested a review from a team as a code owner February 28, 2024 20:56
@patrickseguraoddball patrickseguraoddball requested review from garyjzhao and removed request for a team February 28, 2024 20:56
Copy link
Contributor

@garyjzhao garyjzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function and code look sgood

@patrickseguraoddball patrickseguraoddball merged commit 360a1e8 into main Feb 29, 2024
11 checks passed
@patrickseguraoddball patrickseguraoddball deleted the EASI-3902/op-solutons-filter-view branch February 29, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants