Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOREF] - Revised sort on filter view ops table, added bottom border to last row #984

Merged

Conversation

patrickseguraoddball
Copy link
Contributor

@patrickseguraoddball patrickseguraoddball commented Feb 29, 2024

NOREF

Per slack discussion, slight tweaks to op solutions filter view table

Screenshot 2024-02-29 at 5 07 14 PM

Changes and Description

  • Revised sort on filter view ops table
  • Added bottom border to last row

I left a comment and link in the code about this specific case of sorting

How to test this change

Verify sort and border bottom works as intended

PR Author Review Checklist

  • Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
  • Added or updated tests for backend resolvers or other functions as needed.
  • Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
  • Always make comments, even if it's minor, or if you don't understand why something was done.

@patrickseguraoddball patrickseguraoddball requested a review from a team as a code owner February 29, 2024 23:08
@patrickseguraoddball patrickseguraoddball requested review from garyjzhao and removed request for a team February 29, 2024 23:08
Copy link
Contributor

@garyjzhao garyjzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrickseguraoddball patrickseguraoddball merged commit b119a3f into main Mar 4, 2024
11 checks passed
@patrickseguraoddball patrickseguraoddball deleted the NOREF/sort-filter-view-op-solutions-table branch March 4, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants