Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EASI-4051] Added alert on select solutions #985

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

patrickseguraoddball
Copy link
Contributor

@patrickseguraoddball patrickseguraoddball commented Mar 1, 2024

EASI-4051

Changes and Description

  • Added alert on select solutions when a solution is selected that isn't of type other
  • Added alert on add solution when a solution is added that isn't of type other
  • Added additional prop on Alert component to better match figma
  • Updated snaps

How to test this change

Verify matches Figma
Should only render if a non-other solution is selected

PR Author Review Checklist

  • Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
  • Added or updated tests for backend resolvers or other functions as needed.
  • Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
  • Always make comments, even if it's minor, or if you don't understand why something was done.

@patrickseguraoddball patrickseguraoddball requested a review from a team as a code owner March 1, 2024 16:50
@patrickseguraoddball patrickseguraoddball requested review from garyjzhao and removed request for a team March 1, 2024 16:50
Copy link
Contributor

@garyjzhao garyjzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. QFP

@patrickseguraoddball patrickseguraoddball merged commit fe02fc8 into main Mar 4, 2024
11 checks passed
@patrickseguraoddball patrickseguraoddball deleted the EASI-4051/alert-op-solutions-selected branch March 4, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants