Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EASI-4076] Updating dependencies #994

Merged
merged 3 commits into from
Mar 12, 2024
Merged

[EASI-4076] Updating dependencies #994

merged 3 commits into from
Mar 12, 2024

Conversation

garyjzhao
Copy link
Contributor

@garyjzhao garyjzhao commented Mar 8, 2024 •
edited
Loading

EASI-4076

Changes and Description

  • Updated Luxon to latest
  • Updated Vite to 4.5.2 (v5.x.x requires Node 18)
  • Updated Axios to 1.6.7

How to test this change

  1. yarn install
  2. scripts/dev down && scripts/dev up
  3. Verify the entire app is running fine
  4. try to break app

PR Author Review Checklist

  • Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
  • Added or updated tests for backend resolvers or other functions as needed.
  • Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
  • Always make comments, even if it's minor, or if you don't understand why something was done.

@garyjzhao garyjzhao marked this pull request as ready for review March 8, 2024 20:08
@garyjzhao garyjzhao requested a review from a team as a code owner March 8, 2024 20:08
@garyjzhao garyjzhao requested review from patrickseguraoddball and removed request for a team March 8, 2024 20:08
@ClayBenson94 ClayBenson94 changed the title [NOREF] Updating vite and luxon [EASI-4076] Updating vite and luxon Mar 11, 2024
@garyjzhao garyjzhao changed the title [EASI-4076] Updating vite and luxon [EASI-4076] Updating dependencies Mar 11, 2024
patrickseguraoddball
patrickseguraoddball approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@patrickseguraoddball patrickseguraoddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@garyjzhao garyjzhao merged commit 64efdfd into main Mar 12, 2024
11 checks passed
@garyjzhao garyjzhao deleted the NOREF/updating-some-dependabot branch March 12, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickseguraoddball patrickseguraoddball patrickseguraoddball approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garyjzhao @patrickseguraoddball