Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOREF] change the link to send to read only discussion view #998

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

garyjzhao
Copy link
Contributor

NOREF

Changes and Description

  • Changed where the user gets pushed to after clicking the view discussion link
  • Change 2

How to test this change

  1. Create a notification
  2. Click the view discussion
  3. Verify that you are now in the read only discussion page

PR Author Review Checklist

  • Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
  • Added or updated tests for backend resolvers or other functions as needed.
  • Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
  • Always make comments, even if it's minor, or if you don't understand why something was done.

@garyjzhao garyjzhao requested a review from a team as a code owner March 11, 2024 20:05
@garyjzhao garyjzhao requested review from patrickseguraoddball and removed request for a team March 11, 2024 20:05
@garyjzhao garyjzhao merged commit 57f4369 into main Mar 11, 2024
11 checks passed
@garyjzhao garyjzhao deleted the NOREF/view-discussion-link-change branch March 11, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants