Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLT-642 Adding verify scripts and deployment verification workflow #1402

Merged
merged 33 commits into from
Jan 22, 2025
Merged

PLT-642 Adding verify scripts and deployment verification workflow #1402

merged 33 commits into from
Jan 22, 2025

Conversation

oluwolenpbc
Copy link
Contributor

🎫 Ticket

https://jira.cms.gov/browse/PLT-642

ℹ️ Context

This is a new addition to our github actions workflows to verify our deployments

🧪 Validation

The test will be validated by github actions test runs.

@oluwolenpbc oluwolenpbc requested a review from a team as a code owner October 16, 2024 16:08
gsf
gsf reviewed Dec 27, 2024
View reviewed changes
Copy link
Member

@gsf gsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a lot of duplication to have a separate verify script for each environment. Can it be parameterized?

gsf
gsf reviewed Jan 14, 2025
View reviewed changes
.github/workflows/verify-deploy.yml Show resolved Hide resolved
.github/workflows/verify-deploy.yml Outdated Show resolved Hide resolved
@gsf gsf changed the title Adding verify scripts and deployment verification workflow PLT-642 Adding verify scripts and deployment verification workflow Jan 14, 2025
@gsf
Copy link
Member

gsf commented Jan 21, 2025

I'm still seeing what looks like an error in the latest run: https://github.com/CMSgov/ab2d/actions/runs/12837809052/job/35803223841?pr=1402#step:6:76

@oluwolenpbc oluwolenpbc requested a review from gsf January 21, 2025 22:30
gsf
gsf approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@gsf gsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'd still like to see the output of those curl commands in the logs (via tee or something), and I'd prefer we pull BASIC_AUTH from the parameter store, but that can be changed later.

@oluwolenpbc oluwolenpbc merged commit b816b43 into main Jan 22, 2025
9 checks passed
@oluwolenpbc oluwolenpbc deleted the PLT-642 branch January 22, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsf gsf gsf approved these changes

Assignees

@oluwolenpbc oluwolenpbc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oluwolenpbc @gsf