Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPC-3779: Set JEKYLL_ENV when building docker image #104

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

kyeah
Copy link
Contributor

@kyeah kyeah commented Jan 4, 2024

🎫 Ticket

https://jira.cms.gov/browse/DPC-3779

🛠 Changes

  • Set JEKYLL_ENV so it's used when building the docker image

ℹ️ Context for reviewers

The JEKYLL_ENV isn't read by docker (even it's set in the local environment), so jekyll.environment always evaluates to development.

✅ Acceptance Validation

Build image:

export JEKYLL_ENV=prod
docker-compose -f docker-compose.yml build static_site

Then started a container and checked the _site/index.html to verify that it's using the prod tag for Adobe Analytics.

Also deployed to stage and confirmed it's using the qa URL.

🔒 Security Implications

  • This PR adds a new software dependency or dependencies.
  • This PR modifies or invalidates one or more of our security controls.
  • This PR stores or transmits data that was not stored or transmitted before.
  • This PR requires additional review of its security implications for other reasons.

If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.

@kyeah kyeah changed the title Set JEKYLL_ENV when building docker image DPC-3779: Set JEKYLL_ENV when building docker image Jan 4, 2024
@kyeah kyeah merged commit 8899b7a into master Jan 4, 2024
3 checks passed
@kyeah kyeah deleted the kev/fix-jekyll-tags branch January 4, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants