Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPC-4181 Tealium updates to static site #130

Merged
merged 5 commits into from
Oct 29, 2024

Conversation

MEspositoE14s
Copy link
Contributor

@MEspositoE14s MEspositoE14s commented Oct 1, 2024

🎫 Ticket

https://jira.cms.gov/browse/DPC-4181

🛠 Changes

Updated Tealium scripts in the static site.

ℹ️ Context

The BlastX team asked us to update the Tealium scripts we use in the static site. See CMSgov/dpc-app#2282 for dpc-web update.

🧪 Validation

  • Ran the site locally and verified the new scripts were called.
  • Pushed to stage environment, and currently awaiting validation from the BlastX team that the new scripts are doing what they want. This will not be merged until they sign off.

@@ -1,5 +1,3 @@
version: '3'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was marked as deprecated and no longer used.

Copy link
Contributor

@ashley-weaver ashley-weaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -16,7 +16,7 @@ jobs:
id: lychee
with:
jobSummary: true
args: --no-progress --accept '200..=299, 401, 405' .
args: --no-progress --accept '200..=299, 401, 403, 405' .
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 403 because hhs.gov and hl7.org are returning 403s when called from Github, but 200 when called from everywhere else. Maybe we're hitting a rate limit?

MEspositoE14s added a commit to CMSgov/dpc-app that referenced this pull request Oct 29, 2024
## 🎫 Ticket

https://jira.cms.gov/browse/DPC-4181

## 🛠 Changes

Updated Tealium scripts in dpc-web.

## ℹ️ Context

The BlastX team asked us to update the Tealium scripts we use in
dpc-web. See CMSgov/dpc-static-site#130 for
static site changes.

## 🧪 Validation

Ran the code locally to make sure the new scripts were called.
@MEspositoE14s MEspositoE14s merged commit edf54fd into main Oct 29, 2024
3 checks passed
@MEspositoE14s MEspositoE14s deleted the me/dpc-4181-tealium-update branch October 29, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants