-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DPC-4181 Tealium updates to static site #130
Conversation
@@ -1,5 +1,3 @@ | |||
version: '3' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was marked as deprecated and no longer used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -16,7 +16,7 @@ jobs: | |||
id: lychee | |||
with: | |||
jobSummary: true | |||
args: --no-progress --accept '200..=299, 401, 405' . | |||
args: --no-progress --accept '200..=299, 401, 403, 405' . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added 403 because hhs.gov and hl7.org are returning 403s when called from Github, but 200 when called from everywhere else. Maybe we're hitting a rate limit?
## 🎫 Ticket https://jira.cms.gov/browse/DPC-4181 ## 🛠 Changes Updated Tealium scripts in dpc-web. ## ℹ️ Context The BlastX team asked us to update the Tealium scripts we use in dpc-web. See CMSgov/dpc-static-site#130 for static site changes. ## 🧪 Validation Ran the code locally to make sure the new scripts were called.
🎫 Ticket
https://jira.cms.gov/browse/DPC-4181
🛠 Changes
Updated Tealium scripts in the static site.
ℹ️ Context
The BlastX team asked us to update the Tealium scripts we use in the static site. See CMSgov/dpc-app#2282 for dpc-web update.
🧪 Validation