Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor code in public/src/admin/appearance/themes.js #69

Closed
pebble-fish opened this issue Jan 21, 2025 · 2 comments · May be fixed by #154
Closed

Refactor code in public/src/admin/appearance/themes.js #69

pebble-fish opened this issue Jan 21, 2025 · 2 comments · May be fixed by #154
Assignees
@pebble-fish

Comments

@pebble-fish
Copy link

pebble-fish commented Jan 21, 2025 •
edited
Loading

In the src/.../themes.js file, there are a number of nested functions which make the code difficult for developers to understand and maintain. This not only makes maintenance less efficient but also more expensive, as it breaks the normal linear reading flow.

The issue: https://sonarcloud.io/project/issues?open=AZFmi_6LybYwxy-_uEU6&id=CMU-313_NodeBB&tab=more_info
@pebble-fish
Copy link
Author

I would like to work on this please!

@github-actions GitHub Actions
Copy link

Great! I assigned you (@pebble-fish) to the issue. Have fun working on it!

pebble-fish pushed a commit to pebble-fish/NodeBB that referenced this issue Jan 23, 2025
this commit fixes CMU-313#69
940c9cd
pebble-fish pushed a commit to pebble-fish/NodeBB that referenced this issue Jan 23, 2025
this commit closes CMU-313#69
e7edda0
pebble-fish pushed a commit to pebble-fish/NodeBB that referenced this issue Jan 23, 2025
Closes CMU-313#69
d22e98c
@pebble-fish pebble-fish mentioned this issue Jan 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pebble-fish pebble-fish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactoring code in 'public/src/admin/appearance/themes.js' pebble-fish/NodeBB
1 participant
@pebble-fish