Refactoring code in 'public/src/admin/appearance/themes.js' #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e issue with nested functions. In the src/.../themes.js file, there are a number of nested functions which make the code difficult for developers to understand and maintain. This not only makes maintenance less efficient but also more expensive, as it breaks the normal linear reading flow.
pebble-fish
changed the title
Pull Request Test Coverage Report for Build 12936612122Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the src/.../themes.js file, there are a number of nested if/for/etc. calls. This commit creates helper functions that make the code easier to read, streamlining logic, and removing the nested calls. Resolves #69 if accepted. These changes have been tested via 'npm run lint' and 'npm run test'.