Move the most inner nested function to outside to reduce number of nesting layers in file public/src/admin/dashboard/searches.js #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristinaTrinh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the number of nested functions exceed 4, specifically, the total was 5, I needed to move the function
handleErroroutside and declared it usingconst.The changes do not add more problems or errors to the code as I do
npm run lintandnpm run test.I added two small test cases to check the expected behavior of
handleError:Test 1: Check that
handleErrorcorrectly gives error message when there is an errorTest 2: Check that
handleErrorgivesundefinedobject when there is no error because of the default output ofajaxifyresolves #1