Move the most inner nested function to outside to reduce number of nesting layers in file public/src/admin/dashboard/searches.js

public/src/admin/dashboard/searches.js

@@ -1,22 +1,24 @@
 'use strict';
 
-define('admin/dashboard/searches', ['alerts', 'bootbox'], (alerts, bootbox) => {
-	const ACP = {};
-
-	ACP.init = () => {
-		$('#clear-search-history').on('click', () => {
-			bootbox.confirm('[[admin/dashboard:clear-search-history-confirm]]', function (ok) {
-				if (ok) {
-					socket.emit('admin.clearSearchHistory', function (err) {
-						if (err) {
-							return alerts.error(err);
-						}
-						ajaxify.refresh();
-					});
-				}
+const createACPModule = (alert, ajaxify, socket, $) => {
+	const handleError = (err) => {
+		if (err) {
+			return alert.error(err);
+		}
+		ajaxify.refresh();
+	};
+	const ACP = {
+		init: () => {
+			$('#clear-search-history').on('click', () => {
+				bootbox.confirm('[[admin/dashboard:clear-search-history-confirm]]', function (ok) {
+					if (ok) {
+						socket.emit('admin.clearSearchHistory', handleError);
+					}
+				});
 			});
-		});
+		},
 	};
+	return { handleError, ACP };
+};
 
-	return ACP;
-});
+module.exports = createACPModule;

test/adminDashboardSearches.js

@@ -0,0 +1,48 @@
+'use strict';
+
+const assert = require('assert');
+const createACPModule = require('../public/src/admin/dashboard/searches');
+
+describe('handleError', () => {
+	let handleError;
+	let ACP;
+	beforeEach(() => {
+		const alert = {
+			error: (err) => {
+				throw new Error(`Error: ${err.message}`);
+			},
+		};
+
+		const ajaxify = {
+			refresh: () => 'Refreshed!',
+		};
+
+		const socket = {
+			emit: (event, callback) => {
+				if (event === 'admin.clearSearchHistory') {
+					callback(null);
+				} else {
+					callback(new Error('Unknown event detected'));
+				}
+			},
+		};
+
+		const stubACPModule = createACPModule(alert, ajaxify, socket, () => {});
+		handleError = stubACPModule.handleError;
+		ACP = stubACPModule.ACP;
+	});
+
+	it('should call alert.error when handleError receives an error', () => {
+		try {
+			handleError(new Error('Automated Test Error'));
+			assert(false, 'handleError should have thrown an error');
+		} catch (err) {
+			assert.strictEqual(err.message, 'Error: Automated Test Error');
+		}
+	});
+
+	it('should return "undefined" when handleError receives no error', () => {
+		const result = handleError(null);
+		assert.strictEqual(result, undefined);
+	});
+});