Installing & Running StandardJS static analysis tool #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor this function to reduce its Cognitive Complexity from 27 to the 15 allowed. A helper function was added to reduce the cognitive complexity of the suggested function
fixed minor spacing grammar and syntax errors
fixed Trailing spaces
Creating two default tags 'Homework' and 'Assignment' as default tags for users in src/start.js file
fixing trailing spaces and incorrect indentation
This change approaches the aim of setting two default tags in a different way: - Assign, using client functions provided by NodeBB, two tags 'Homework' and 'Assignment' for the default post 'Welcome to your NodeBB!' - Needs help and further development on the function getTopicIdByTitle(title) -- logics need to be fixed based on the database structure
fixing trailing spaces, incorrect indentation and definition errors
* Added refactored code and fixed errors for lint. --------- Co-authored-by: jullia andrei <[email protected]>
updated src/topics/create.js and notifications.json to handle course faculty notifications.
Add "Homework" and "Assignment" categories to the tags
Refactoring code in src/groups/update.js
Refactored code in public/src/admin/manage/digest.js
Refactored code in src/socket.io/admin/rooms.js
refactor Flags.validate in src/flags.js
Pull Request Test Coverage Report for Build 11490310328Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots of the terminal output from installing StandardJS:
Screenshots of the terminal output from running StandardJS:
