Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installing & Running StandardJS static analysis tool #101

Closed
wants to merge 32 commits into from
Closed

Installing & Running StandardJS static analysis tool #101

wants to merge 32 commits into from

Commits on Sep 9, 2024

  1. add deadline

    @github-classroom
    github-classroom[bot] authored Sep 9, 2024
    Configuration menu
    Copy the full SHA
    576fb84 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Refactored rooms.io code from complexity 16 to 15

    @alicekang1
    alicekang1 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    7e47494 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Refactoring code in src/groups/update.js 

    Refactor this function to reduce its Cognitive Complexity from 27 to the 15 allowed. 
A helper function was added to reduce the cognitive complexity of the suggested function
    @JasmineRocket
    JasmineRocket authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    f5f5500 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2024

  1. fix "no-trailing-space" error

    @mhli1260
    mhli1260 authored Sep 21, 2024
    Configuration menu
    Copy the full SHA
    be7d2cb View commit details
    Browse the repository at this point in the history

  2. fixing "trailing space not allowed" error

    @mhli1260
    mhli1260 committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    03aed02 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. fixing grammar errors in update.js 

    fixed minor spacing grammar and syntax errors
    @JasmineRocket
    JasmineRocket authored Sep 23, 2024
    Configuration menu
    Copy the full SHA
    fd2bda9 View commit details
    Browse the repository at this point in the history

  2. Update update.js 

    fixed Trailing spaces
    @JasmineRocket
    JasmineRocket authored Sep 23, 2024
    Configuration menu
    Copy the full SHA
    b6c3308 View commit details
    Browse the repository at this point in the history

  3. Add "Homework" and "Assignment" categories to the tags 

    Creating two default tags 'Homework' and 'Assignment' as default tags for users in src/start.js file
    @JasmineRocket
    JasmineRocket authored Sep 23, 2024
    Configuration menu
    Copy the full SHA
    f46f43b View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. fixing grammar 

    fixing trailing spaces and incorrect indentation
    @JasmineRocket
    JasmineRocket authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    b097dd5 View commit details
    Browse the repository at this point in the history

  2. Adding 'Homework' and 'Assignment' Tags for default NodeBB Post 

    This change approaches the aim of setting two default tags in a different way:
- Assign, using client functions provided by NodeBB, two tags 'Homework' and 'Assignment' for the default post 'Welcome to your NodeBB!'
- Needs help and further development on the function getTopicIdByTitle(title) -- logics need to be fixed based on the database structure
    @JasmineRocket
    JasmineRocket authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    7c4b225 View commit details
    Browse the repository at this point in the history

  3. fixing grammar 

    fixing trailing spaces, incorrect indentation and definition errors
    @JasmineRocket
    JasmineRocket authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    314b43b View commit details
    Browse the repository at this point in the history

  4. adjusted require statement and fixing grammar

    @JasmineRocket
    JasmineRocket authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    99d68dd View commit details
    Browse the repository at this point in the history

  5. Added project 1 refactored code - Jullia. (#21) 

    * Added refactored code and fixed errors for lint.

---------

Co-authored-by: jullia andrei <[email protected]>
    @jullia02
    jullia02 and jullia andrei authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    4c14ce8 View commit details
    Browse the repository at this point in the history

  6. Added check for admin replies and handled notification bundling.

    jullia andrei committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    c5703d7 View commit details
    Browse the repository at this point in the history

  7. Changed notification message for admin replies.

    jullia andrei committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    0594f86 View commit details
    Browse the repository at this point in the history

  8. Changed notification message to course-faculty role.

    jullia andrei committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    f63f393 View commit details
    Browse the repository at this point in the history

  9. disabling call in start.start

    @JasmineRocket
    JasmineRocket authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a471b87 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Merge pull request #25 from CMU-313/jullia/instructor-notif-ft 

    updated src/topics/create.js and notifications.json to handle course faculty notifications.
    @mhli1260
    mhli1260 authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    75ac75d View commit details
    Browse the repository at this point in the history

  2. deleting unnecessary comments

    @JasmineRocket
    JasmineRocket authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    1eb5ecc View commit details
    Browse the repository at this point in the history

  3. recovered start.js

    @JasmineRocket
    JasmineRocket authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    0f8b99b View commit details
    Browse the repository at this point in the history

  4. Fixing parsing errors

    @JasmineRocket
    JasmineRocket authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    4bf4e15 View commit details
    Browse the repository at this point in the history

  5. Fixing line syntax and definition issues

    @JasmineRocket
    JasmineRocket authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    94fca54 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #26 from CMU-313/jasmine/default-topic-tags 

    Add "Homework" and "Assignment" categories to the tags
    @JasmineRocket
    JasmineRocket authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    1742f8a View commit details
    Browse the repository at this point in the history

  7. refactor digest.js to reduce nested functions

    @mhli1260
    mhli1260 authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    ab4037b View commit details
    Browse the repository at this point in the history

  8. Merge pull request #16 from CMU-313/JasmineRocket-patch-3 

    Refactoring code in src/groups/update.js
    @JasmineRocket
    JasmineRocket authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    7d96899 View commit details
    Browse the repository at this point in the history

  9. removed trailing space, but sitll getting file erorrs

    @alicekang1
    alicekang1 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    3dd828d View commit details
    Browse the repository at this point in the history

  10. Merge pull request #27 from CMU-313/mia/refactor-digest 

    Refactored code in public/src/admin/manage/digest.js
    @mhli1260
    mhli1260 authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    7bed986 View commit details
    Browse the repository at this point in the history

  11. Merge pull request #28 from CMU-313/alice/refactor 

    Refactored code in src/socket.io/admin/rooms.js
    @alicekang1
    alicekang1 authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    98f6e71 View commit details
    Browse the repository at this point in the history

  12. refactor Flags.validate()

    @tu2463
    tu2463 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c030b92 View commit details
    Browse the repository at this point in the history

  13. Merge pull request #29 from CMU-313/cheyut/refactor-Flags-Validate 

    refactor Flags.validate in src/flags.js
    @tu2463
    tu2463 authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e90b966 View commit details
    Browse the repository at this point in the history

  14. Added team member names to readme.

    jullia andrei committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e332479 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. adding install and run StandardJS into test workflow

    @mhli1260
    mhli1260 committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    159feac View commit details
    Browse the repository at this point in the history