Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mainline topic search feature #100

Closed
wants to merge 67 commits into from
Closed

Fix mainline topic search feature #100

wants to merge 67 commits into from

Conversation

wandrew004
Copy link

Updated changes for topic search. Tests are now passing.
image

github-classroom bot and others added 30 commits September 9, 2024 18:42
@github-classroom
add deadline
b80d2a8
@wandrew004
refactor render to reduce function depth
3efe4ab
@wandrew004
fix spacing for autotests
3774176
@wandrew004
update README with team members
289b26a
@wandrew004
fix spacing
aaa5a04
@bestpantusen
Merge pull request #20 from CMU-313/README-update
6823c95 
update README with team members
@zhanwen22
merged wennaz p1 changes in scr/flags
11f8c38
@zzzannie
added annie's change from p1
39b7df9
@bestpantusen
Added search bar and button to forum
fc1174c
@bestpantusen
Added comments
1f0e2f4
Merged Changes from project 1
e3b50b1
Jordan_P1
e54f467
Jordan_P1
cc15022
@bestpantusen
Deleted some space for lint
6738015
@wandrew004
Merge pull request #21 from CMU-313/p1-changes-annie
fa07412 
P1 Changes Annie public/src/admin/settings/navigation.js
@wandrew004
Merge pull request #19 from CMU-313/p1-changes-andrew
99de34a 
P1 changes andrew
@wandrew004
Merge pull request #22 from CMU-313/wennaz-p1
8cb3c59 
Merged wennaz p1 changes in scr/flags
Added a function that handles the UI for the search function implemented
90454e5
Jordan P1
1a03b6e
added search rendering to public/src/client/ category.js
442d40a
@wandrew004
add route for topic search
2098822
@wandrew004
add controller for topic search
52caec4
@wandrew004
add to schema docs
8a67303
@wandrew004
openapi documentation for topic search
b1b1e67
@wandrew004
fix spacing
4292d81
@wandrew004
fix spacing
8891ea0
Added rendering function to diplay topics searched
5ee3595
@bestpantusen
created new nodebb-theme-penguins folder, added search bar in the tem…
d230833 
…plates/partials/topic-list-bar.tpl
@zhanwen22
added bookmark feature to topics controller, topics routes, and user …
546a74d 
…routes
@bestpantusen
fixed lint
6c486ee
wandrew004 and others added 28 commits September 25, 2024 21:53
@wandrew004
Merge pull request #29 from CMU-313/search-route-controller
0a48d50 
added backend API for topic search
@zzzannie
fix lint error
0b76b29
@zzzannie
fix lint error in correct package.json
0a12583
@wandrew004
Merge pull request #28 from CMU-313/search-api-tests
b403d14 
add unit tests for search api
@wandrew004
Merge pull request #27 from CMU-313/bookmark-api
954e9af 
Added routes and controller for bookmark
@zzzannie
trying to fix set testing issue
122cd08
@zzzannie
added api endpoints for bookmark
1f5c6f1
@zzzannie
removed code from another feature (bookmark)
dd39a2a
@zzzannie
removed code from another feature (bookmark)
27f5b33
@zzzannie
removed getSetMember
963d45c
@zzzannie
set up the test; TODO: call the function
1105b3c
@zhanwen22
bookmark open api fully added and connected to controller
e5c1e7b
@zzzannie
fixed merge issue
4816c6f
@wandrew004
Merge pull request #30 from CMU-313/search-api-tests
babde73 
Add unit test for search bar - fix set operation issue
@bestpantusen
created handleBookmarks function to handle posts that are bookmarked
8276dce
@bestpantusen
fixed lint
a8d7ed2
@bestpantusen
added database to config
7c9e27a
Replaced all placeholders for input to event listeners, updated topic…
5e263cd 
… parameters and attempted to debug
@wandrew004
add post and update for bookmark
6185159
@zzzannie
new tests in existing test file
5719ece
@wandrew004
add userguide
4e3c365
@wandrew004
Merge pull request #31 from CMU-313/bookmark-api
9a935ac 
Added bookmarks openapi
@wandrew004
Merge pull request #32 from CMU-313/sprint2-best
e1e0b8c 
Implement Bookmark Functionality for Rendering Bookmarked Topics
@wandrew004
Merge pull request #33 from CMU-313/bookmark-post-api
0ac87fa 
add post and update for bookmark
@wandrew004
Merge pull request #34 from CMU-313/Rendering_Search
63784be 
Replaced all Input Placeholders & Updated Topic Parameters for the Topic Search Function
@wandrew004
Merge pull request #35 from CMU-313/search-api-tests
f9172de 
Unit Test for Search API - existing test file
@wandrew004
update readme
dd23fe3
@wandrew004
fix topic search feature
8bebd3d
@wandrew004 wandrew004 closed this Oct 24, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11490048946

Details

  • 75 of 97 (77.32%) changed or added relevant lines in 11 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 82.697%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/controllers/write/topics.js 2 3 66.67%
src/webserver.js 17 19 89.47%
src/topics/search.js 23 26 88.46%
src/api/topics.js 8 13 61.54%
src/middleware/render.js 0 11 0.0%
Files with Coverage Reduction New Missed Lines %
src/webserver.js 2 73.98%
Totals Coverage Status
Change from base Build 10688272652: 0.03%
Covered Lines: 22384
Relevant Lines: 25641
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wandrew004 @coveralls @bestpantusen @zhanwen22 @zzzannie @JordanFnsg