Adding an IsInstructor Function into src/privileges/users.js #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main components of this pull request are an IsInstructor function to check if a user is considered an instructor and test cases for it in test/user.js. This is intended for the highlighting/flagging instructor posts feature.
However, although the frontend (it has visible design changes) and backend are working separately, we are still running into issues with calling the function in posts.tpl and topics_list.tpl. We also went to office hours for TA help and were unable to call the function successfully in the frontend.
Context:
Before choosing this, I experimented with various options of tracking if a user is an instructor including adding an isInstructor attribute to user in the database, adding fields to postData, and making functions in src/posts/data.js and src/posts/user.js.
I eventually decided to try making a function in user privileges because I saw that frontend template files could successfully call privileges.isAdminOrMod, which checks if the signed-in user is an administrator or moderator. Hopefully, with more experimentation, we can call the function successfully.