generated from CMU-313/NodeBB
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate Prettier as Static Analysis Tool #88
Open
guanjiecheng
wants to merge
57
commits into
CMU-313:f24
Choose a base branch
from
CMU-313:tools/Prettier
base: f24
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shanting - Project 1 changes
project1 changes
add q&a page
Features/us39 UI
amanda/autoresolve LGTM
Us2/addcheckboxannonymous - Ensure that annonymous posts are displayed annonymously
guanjiecheng
changed the title
Tools/prettier
Investigate Prettier as Static Analysis Tool
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Added Prettier to the project to ensure that code is formatted the same way. This saves time from fixing ESLint errors as we no longer have to manually go in and make the style changes ourselves. Also, it ensures that the code is easy to read and maintain, which can help save time understanding the code and finding errors.
Why
Investigating Static analysis tools for Tools Checkpoint
How
NPM installed prettier. https://github.com/CMU-313/nodebb-f24-the-turtles/blob/f391b0e24df422e4993e4cbe698a34e3f13c6864/package.json#L124
Testing
Portion of files formatted by Prettier or unformatted if it complies with all styling rules.