forked from CMU-313/cmu-313-f24-nodebb-f24-NodeBB
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend implementation of isAnswered feature, including isAnswered field in posts, storing answered status, adding logic/property to edit post data, and API endpoints #27
Open
eunseokk
wants to merge
12
commits into
f24
Choose a base branch
from
isAnswered
base: f24
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added one emoji reaction - primitive start
… isAnswered route into api.js for API endpoint creation
VeronicaPim
force-pushed
the
f24
branch
2 times, most recently
from
October 9, 2024 21:45
bf0fcb8
to
29c75ea
Compare
VeronicaPim
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is good in fixing the linter errors.
VeronicaPim
approved these changes
Oct 9, 2024
VeronicaPim
approved these changes
Oct 9, 2024
VeronicaPim
approved these changes
Oct 9, 2024
VeronicaPim
approved these changes
Oct 9, 2024
VeronicaPim
approved these changes
Oct 9, 2024
VeronicaPim
approved these changes
Oct 9, 2024
eunseokk
changed the title
IsAnswered Feature (Backend)
Backend implementation of isAnswered feature, including isAnswered field in posts, storing answered status, adding logic/property to edit post data, and API endpoints
Oct 9, 2024
VeronicaPim
requested changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually you need to make sure to remove trailing spaces in this file - for example in line 2533:1 here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #15
Backend implementation including:
Current Status:
Potential Next Steps:
Would like feedback for the commit up to fd84e7b