forked from CMU-313/cmu-313-f24-nodebb-f24-NodeBB
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual lint fixes for checkbox frontend attempt #32
Open
VeronicaPim
wants to merge
28
commits into
f24
Choose a base branch
from
lint-tesing
base: f24
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added one emoji reaction - primitive start
Added anonymous checkbox to the UI
eunseokk
requested changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to debug some of the errors popping up, check the modules section!
VeronicaPim
changed the title
Lint tesing **EDIT THIS**
Manual lint fixes for checkbox frontend attemp
Oct 11, 2024
VeronicaPim
changed the title
Manual lint fixes for checkbox frontend attemp
Manual lint fixes for checkbox frontend attempt
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkbox Frontend & Manual Lint Fixes
Summary
This PR includes attempted progress on the checkbox frontend feature #13 , where users can toggle the "answered/unanswered" status of posts. Additionally, this PR highlights extensive manual work on resolving linter issues. Due to the linter not working properly, I manually located and fixed specific lines of code that caused issues, then committed, pushed, and checked the results iteratively.
Key Changes:
Checkbox Frontend Feature:
src/views/partials/posts/check-uncheck.tpl
, other related frontend files.Manual Lint Fixes:
app.js
,edit.js
,uploads.js
.edit.js
and lines 20-21 inapp.js
).Challenges Encountered:
Linter Not Working:
Frontend Testing and Integration:
Current Status:
To Reviewers:
Testing Instructions:
checkbox-linter-fixes
branch.npm install
and ensure the project builds successfully.