Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of Additional Information Button - For Sub Issue 17 #26

Merged
merged 14 commits into from
Sep 22, 2024

Conversation

lexik04
Copy link

@lexik04 lexik04 commented Sep 21, 2024

Status: Complete

Fixes Issue #17

Below is a photo of the newly created button in the left sidebar called "Additional Information". This is was originally in my created template called lexi, but now is in our team's new front-end repo. The new repo can be found here: https://github.com/CMU-313/nodebb-frontend-f24-team-tbd-1.git

  1. This code was added to nodebb-frontend-f24-team-tbd-1/templates/partials/sidebar-left.tpl
        <!-- Generated By Chat GPT -->
        <li class="nav-item mx-2" title="Additional Info">
            <a class="nav-link d-flex gap-2 align-items-center" href="/additional-info">
                <i class="fa fa-fw fa-info-circle"></i> 
                <span class="nav-text small visible-open fw-semibold">Additional Information</span>
            </a>
        </li>

Here is a photo of the button that I created in the left sidebar called Additional Information:

Screenshot 2024-09-21 at 9 27 09 PM

As of now when the Additional Information Button is clicked, it says page not found. The next step is to set up the routes, controller, and API for this newly created page.

@coveralls
Copy link

coveralls commented Sep 21, 2024

Pull Request Test Coverage Report for Build 10978266789

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.666%

Totals Coverage Status
Change from base Build 10774631366: 0.0%
Covered Lines: 22322
Relevant Lines: 25582

💛 - Coveralls

@lexik04 lexik04 self-assigned this Sep 21, 2024
@lexik04 lexik04 merged commit c33970c into f24 Sep 22, 2024
2 checks passed
@lexik04 lexik04 changed the title Creation of Additional Information Button Creation of Additional Information Button - For Sub Issue 17 Sep 22, 2024
@lexik04 lexik04 linked an issue Sep 24, 2024 that may be closed by this pull request
@lexik04 lexik04 requested a review from ay0503 October 9, 2024 17:32
@ay0503
Copy link

ay0503 commented Oct 9, 2024

looks good to me!

@lexik04 lexik04 added the enhancement New feature or request label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sub Issue: A Button for Additional Information Form
3 participants