libpressio version 0.34.3

- Bug Fix: Previously, when clone was introduced, it would not also clone the metrics object associated with a particular compressor plugin. This was unintended. Now, the metrics object is cloned to improve thread safety
CODARcode · Feb 28, 2020 · d5ccdfd · d5ccdfd
1 parent 4733326
commit d5ccdfd
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 2 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -1,5 +1,5 @@
 cmake_minimum_required(VERSION 3.13 FATAL_ERROR)
-project(libpressio VERSION "0.34.2" LANGUAGES CXX C)
+project(libpressio VERSION "0.34.3" LANGUAGES CXX C)
 
 #correct was to set a default build type
 # https://blog.kitware.com/cmake-and-the-default-build-type/

diff --git a/COPYRIGHT.txt b/COPYRIGHT.txt
@@ -1,6 +1,6 @@
 Copyright © 2020 , UChicago Argonne, LLC
 All Rights Reserved
-[libpressio, Version 0.34.2]
+[libpressio, Version 0.34.3]
 Robert Underwood
 Argonne National Laboratory
 

diff --git a/include/libpressio_ext/cpp/compressor.h b/include/libpressio_ext/cpp/compressor.h
@@ -19,6 +19,27 @@ class libpressio_compressor_plugin {
   public:
 
   libpressio_compressor_plugin() noexcept;
+  libpressio_compressor_plugin(libpressio_compressor_plugin const& plugin):
+    error(plugin.error),
+    metrics_plugin(plugin.metrics_plugin->clone())
+  {}
+  libpressio_compressor_plugin& operator=(libpressio_compressor_plugin const& plugin)
+  {
+    error = plugin.error;
+    metrics_plugin = plugin.metrics_plugin->clone();
+    return *this;
+  }
+  libpressio_compressor_plugin(libpressio_compressor_plugin&& plugin) noexcept:
+    error(std::move(plugin.error)),
+    metrics_plugin(std::move(plugin.metrics_plugin))
+    {}
+  libpressio_compressor_plugin& operator=(libpressio_compressor_plugin&& plugin) noexcept
+  {
+    error = std::move(plugin.error);
+    metrics_plugin = std::move(plugin.metrics_plugin);
+    return *this;
+  }
+
 
   /** compressor should free their global memory in the destructor */
   virtual ~libpressio_compressor_plugin();