Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TST] Bump pytest>=8 and resolve deprecations #514

Merged
merged 5 commits into from
May 16, 2024

Conversation

drewejohnson
Copy link
Collaborator

@drewejohnson drewejohnson commented May 14, 2024

Closes #436 by bumping pytest to >=8. In doing that, we need to remove our reliance on a deprecated feature, namely patterns like

with pytest.raises(None) as record:
    pass
assert len(record) == 0

when checking no warnings are raised. Now, we use the recwarn fixture like

def test_sample(recwarn):
    assert len(recwarn) == 0

Constructing a RegularPolygon has slightly changed in Matplotlib 3.8 to only accept the xy location and number of edges as positional arguments. So now the radius and orientation arguments are passed as keyword arguments

@drewejohnson drewejohnson added the testing Related to our test suite label May 14, 2024
@drewejohnson drewejohnson self-assigned this May 14, 2024
> Passing all but the very few first arguments positionally in the
  construction of Artists

Deprecated in matplotlib 3.6, removed in 3.8
@DanKotlyar
Copy link
Contributor

@drewejohnson should I merge?

@drewejohnson drewejohnson merged commit 3260a70 into CORE-GATECH-GROUP:main May 16, 2024
4 checks passed
@drewejohnson drewejohnson deleted the test-deps/436 branch May 16, 2024 17:28
@drewejohnson drewejohnson added this to the 0.11.0 milestone Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Related to our test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST Bump test dependencies
2 participants