-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Support passing depletion reader settings at construction #516
ENH: Support passing depletion reader settings at construction #516
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this approach a lot.
@DanKotlyar thanks! Let's let this sit for a few more days to try to get some more feedback. I think this is a good step, but want to give people the chance to chime in on the potential removal of the global |
@DanKotlyar ready for your re-review and merge if approved |
Not really a deprecation yet but this is my first step into #339. The depletion reader can be fully configured at construction like
All of the arguments are optional, defaulting to
None
. If not given, the values in therc
global settings object is used.Starting small because I want to get buy in from @DanKotlyar and other users before applying this approach to all the readers.
Current plan roll out (to be re-posted into #339) is
rc
unchangedrc
object raises a deprecation warning. transition tests away from usingrc
in favor of direct constructionrc
object from the code baseThis should give enough time for users to update their applications to move away from the
rc
objectMake sure you have read over the developer guide to ease
the review process. These include:
docs/contributors.rst
TODO
versionadded
tag in the docstrings for these parameters