Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submission Box Settings Form #221

Merged
merged 21 commits into from
Nov 28, 2023
Merged

Submission Box Settings Form #221

merged 21 commits into from
Nov 28, 2023

Conversation

te-sa
Copy link
Contributor

@te-sa te-sa commented Nov 25, 2023 •
edited
Loading

Description:

I created a basic form to enter submission box settings. It follows the layout designed on Figma.

There is a known issue that leads to the multiline TextField to reload when the page is first loaded and shift the layout, I could not find a good way to deal with that.

Also, tests will fail locally due to a database error introduced in a different PR.

Related Issues:

mui/material-ui#219

Checklist:

Before submitting this pull request, please make sure of the following:

  • My code follows the style guidelines of this project
  • My changes generate no new warnings
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
    • Are there representative cases to test the program?
    • Are there tests for edge cases? (empty strings, negatives, infinity, off-by-one errors, etc.)
  • New and existing unit tests pass locally with my changes
  • I have resolved any merge conflicts with the latest master branch.
  • I have labeled my PR
  • I have assigned myself to the PR
  • I have run the E2E tests on my branch

Screenshots or Visual Changes (if applicable):

Screenshot 2023-11-27 at 19 40 32

Documentation

Link to documentation if pages were added or changed.

@te-sa te-sa added the enhancement New feature or request label Nov 25, 2023
@te-sa te-sa self-assigned this Nov 25, 2023
@te-sa te-sa linked an issue Nov 25, 2023 that may be closed by this pull request
Create form to create submission boxes #219
Closed
@ketphan02
Copy link
Contributor

Component Test Results

Run start date: 11/25/2023, 9:22:06 PM

Duration: 0s

Tests run stats

  • 📚 total tests: 2
  • ✔️ passed: 2
  • ❌ failed: 0
  • 🔜 skipped: 0
  • ⚠️ skipped by Cypress: 0
  • ❇️ other: 0

Failed tests

Click to reveal

Skipped tests

Click to reveal

Skipped tests by Cypress

Click to reveal

@ketphan02
Copy link
Contributor

Component Test Results

Run start date: 11/25/2023, 10:16:28 PM

Duration: 0s

Tests run stats

  • 📚 total tests: 2
  • ✔️ passed: 2
  • ❌ failed: 0
  • 🔜 skipped: 0
  • ⚠️ skipped by Cypress: 0
  • ❇️ other: 0

Failed tests

Click to reveal

Skipped tests

Click to reveal

Skipped tests by Cypress

Click to reveal

@ketphan02
Copy link
Contributor

Component Test Results

Run start date: 11/25/2023, 10:50:08 PM

Duration: 0s

Tests run stats

  • 📚 total tests: 2
  • ✔️ passed: 2
  • ❌ failed: 0
  • 🔜 skipped: 0
  • ⚠️ skipped by Cypress: 0
  • ❇️ other: 0

Failed tests

Click to reveal

Skipped tests

Click to reveal

Skipped tests by Cypress

Click to reveal

@ketphan02
Copy link
Contributor

Component Test Results

Run start date: 11/25/2023, 11:00:53 PM

Duration: 0s

Tests run stats

  • 📚 total tests: 2
  • ✔️ passed: 2
  • ❌ failed: 0
  • 🔜 skipped: 0
  • ⚠️ skipped by Cypress: 0
  • ❇️ other: 0

Failed tests

Click to reveal

Skipped tests

Click to reveal

Skipped tests by Cypress

Click to reveal

@ketphan02
Copy link
Contributor

Component Test Results

Run start date: 11/26/2023, 10:49:01 PM

Duration: 0s

Tests run stats

  • 📚 total tests: 2
  • ✔️ passed: 2
  • ❌ failed: 0
  • 🔜 skipped: 0
  • ⚠️ skipped by Cypress: 0
  • ❇️ other: 0

Failed tests

Click to reveal

Skipped tests

Click to reveal

Skipped tests by Cypress

Click to reveal

@te-sa te-sa changed the title Submission Box Creation Form Submission Box Settings Form Nov 26, 2023
@te-sa te-sa marked this pull request as ready for review November 26, 2023 23:01
@ketphan02
Copy link
Contributor

Component Test Results

Run start date: 11/26/2023, 11:40:07 PM

Duration: 0s

Tests run stats

  • 📚 total tests: 2
  • ✔️ passed: 2
  • ❌ failed: 0
  • 🔜 skipped: 0
  • ⚠️ skipped by Cypress: 0
  • ❇️ other: 0

Failed tests

Click to reveal

Skipped tests

Click to reveal

Skipped tests by Cypress

Click to reveal

@ketphan02
Copy link
Contributor

Component Test Results

Run start date: 11/26/2023, 11:43:58 PM

Duration: 0s

Tests run stats

  • 📚 total tests: 2
  • ✔️ passed: 2
  • ❌ failed: 0
  • 🔜 skipped: 0
  • ⚠️ skipped by Cypress: 0
  • ❇️ other: 0

Failed tests

Click to reveal

Skipped tests

Click to reveal

Skipped tests by Cypress

Click to reveal

Hedgemon4
Hedgemon4 requested changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@Hedgemon4 Hedgemon4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment on the todo you left. Otherwise good work.

src/app/submission-box/settings/page.tsx Outdated Show resolved Hide resolved
@ketphan02
Copy link
Contributor

Component Test Results

Run start date: 11/27/2023, 12:28:15 AM

Duration: 0s

Tests run stats

  • 📚 total tests: 2
  • ✔️ passed: 2
  • ❌ failed: 0
  • 🔜 skipped: 0
  • ⚠️ skipped by Cypress: 0
  • ❇️ other: 0

Failed tests

Click to reveal

Skipped tests

Click to reveal

Skipped tests by Cypress

Click to reveal

@ketphan02
Copy link
Contributor

Component Test Results

Run start date: 11/27/2023, 12:34:37 AM

Duration: 0s

Tests run stats

  • 📚 total tests: 2
  • ✔️ passed: 2
  • ❌ failed: 0
  • 🔜 skipped: 0
  • ⚠️ skipped by Cypress: 0
  • ❇️ other: 0

Failed tests

Click to reveal

Skipped tests

Click to reveal

Skipped tests by Cypress

Click to reveal

@te-sa te-sa requested a review from Hedgemon4 November 27, 2023 00:40
@ketphan02
Copy link
Contributor

Component Test Results

Run start date: 11/27/2023, 12:41:22 AM

Duration: 0s

Tests run stats

  • 📚 total tests: 2
  • ✔️ passed: 2
  • ❌ failed: 0
  • 🔜 skipped: 0
  • ⚠️ skipped by Cypress: 0
  • ❇️ other: 0

Failed tests

Click to reveal

Skipped tests

Click to reveal

Skipped tests by Cypress

Click to reveal

@ketphan02
Copy link
Contributor

Component Test Results

Run start date: 11/28/2023, 8:43:37 PM

Duration: 0s

Tests run stats

  • 📚 total tests: 2
  • ✔️ passed: 2
  • ❌ failed: 0
  • 🔜 skipped: 0
  • ⚠️ skipped by Cypress: 0
  • ❇️ other: 0

Failed tests

Click to reveal

Skipped tests

Click to reveal

Skipped tests by Cypress

Click to reveal

@ketphan02
Copy link
Contributor

E2E Test Results

Run start date: 11/28/2023, 8:42:48 PM

Duration: 73s

Tests run stats

  • 📚 total tests: 30
  • ✔️ passed: 28
  • ❌ failed: 2
  • 🔜 skipped: 0
  • ⚠️ skipped by Cypress: 0
  • ❇️ other: 0

Failed tests

Click to reveal
  • 💢 Path: cypress/e2e/app/login.cy.ts, test: Should allow user to create an account, login, and logout
  • 💢 Path: cypress/e2e/app/submission-box/settings.cy.ts, test: Should allow user to move on to the next page

Skipped tests

Click to reveal

Skipped tests by Cypress

Click to reveal

justino599
justino599 previously approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@justino599 justino599 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge 👍

ketphan02
ketphan02 previously approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@ketphan02 ketphan02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘🤘
LGTM

@ketphan02 ketphan02 dismissed stale reviews from justino599 and themself via 9305bb6 November 28, 2023 20:58
@ketphan02
Copy link
Contributor

Component Test Results

Run start date: 11/28/2023, 9:00:06 PM

Duration: 0s

Tests run stats

  • 📚 total tests: 2
  • ✔️ passed: 2
  • ❌ failed: 0
  • 🔜 skipped: 0
  • ⚠️ skipped by Cypress: 0
  • ❇️ other: 0

Failed tests

Click to reveal

Skipped tests

Click to reveal

Skipped tests by Cypress

Click to reveal

@ketphan02
Copy link
Contributor

E2E Test Results

Run start date: 11/28/2023, 9:03:24 PM

Duration: 74s

Tests run stats

  • 📚 total tests: 30
  • ✔️ passed: 28
  • ❌ failed: 2
  • 🔜 skipped: 0
  • ⚠️ skipped by Cypress: 0
  • ❇️ other: 0

Failed tests

Click to reveal
  • 💢 Path: cypress/e2e/app/login.cy.ts, test: Should allow user to create an account, login, and logout
  • 💢 Path: cypress/e2e/app/submission-box/settings.cy.ts, test: Should allow user to move on to the next page

Skipped tests

Click to reveal

Skipped tests by Cypress

Click to reveal

ketphan02
ketphan02 previously approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@ketphan02 ketphan02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thumbs up!

@ketphan02
Copy link
Contributor

Component Test Results

Run start date: 11/28/2023, 9:06:13 PM

Duration: 0s

Tests run stats

  • 📚 total tests: 2
  • ✔️ passed: 2
  • ❌ failed: 0
  • 🔜 skipped: 0
  • ⚠️ skipped by Cypress: 0
  • ❇️ other: 0

Failed tests

Click to reveal

Skipped tests

Click to reveal

Skipped tests by Cypress

Click to reveal

@ketphan02
Copy link
Contributor

E2E Test Results

Run start date: 11/28/2023, 9:05:59 PM

Duration: 69s

Tests run stats

  • 📚 total tests: 30
  • ✔️ passed: 28
  • ❌ failed: 2
  • 🔜 skipped: 0
  • ⚠️ skipped by Cypress: 0
  • ❇️ other: 0

Failed tests

Click to reveal
  • 💢 Path: cypress/e2e/app/login.cy.ts, test: Should allow user to create an account, login, and logout
  • 💢 Path: cypress/e2e/app/submission-box/settings.cy.ts, test: Should allow user to move on to the next page

Skipped tests

Click to reveal

Skipped tests by Cypress

Click to reveal

@ketphan02
Copy link
Contributor

E2E Test Results

Run start date: 11/28/2023, 9:09:39 PM

Duration: 94s

Tests run stats

  • 📚 total tests: 30
  • ✔️ passed: 24
  • ❌ failed: 6
  • 🔜 skipped: 0
  • ⚠️ skipped by Cypress: 0
  • ❇️ other: 0

Failed tests

Click to reveal
  • 💢 Path: cypress/e2e/app/signup.cy.ts, test: Should not allow the user to sign up with no information in fields
  • 💢 Path: cypress/e2e/app/signup.cy.ts, test: Should give the user error feedback when both password fields do not match
  • 💢 Path: cypress/e2e/app/signup.cy.ts, test: Should allow the creation of a valid user
  • 💢 Path: cypress/e2e/app/signup.cy.ts, test: Should not allow the creation of an account that already is using email
  • 💢 Path: cypress/e2e/app/signup.cy.ts, test: Should toggle password confirmation visibility when clicking on icon button
  • 💢 Path: cypress/e2e/app/submission-box/settings.cy.ts, test: Should allow user to move on to the next page

Skipped tests

Click to reveal

Skipped tests by Cypress

Click to reveal

@ketphan02
Copy link
Contributor

Component Test Results

Run start date: 11/28/2023, 9:13:58 PM

Duration: 0s

Tests run stats

  • 📚 total tests: 2
  • ✔️ passed: 2
  • ❌ failed: 0
  • 🔜 skipped: 0
  • ⚠️ skipped by Cypress: 0
  • ❇️ other: 0

Failed tests

Click to reveal

Skipped tests

Click to reveal

Skipped tests by Cypress

Click to reveal

@ketphan02
Copy link
Contributor

E2E Test Results

Run start date: 11/28/2023, 9:17:15 PM

Duration: 70s

Tests run stats

  • 📚 total tests: 30
  • ✔️ passed: 30
  • ❌ failed: 0
  • 🔜 skipped: 0
  • ⚠️ skipped by Cypress: 0
  • ❇️ other: 0

Failed tests

Click to reveal

Skipped tests

Click to reveal

Skipped tests by Cypress

Click to reveal

@ketphan02 ketphan02 self-requested a review November 28, 2023 21:21
ketphan02
ketphan02 approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@ketphan02 ketphan02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

abundance of thumbs up

justino599
justino599 reviewed Nov 28, 2023
View reviewed changes
Copy link
Contributor

@justino599 justino599 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests W

Hedgemon4
Hedgemon4 reviewed Nov 28, 2023
View reviewed changes
Copy link
Contributor

@Hedgemon4 Hedgemon4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

.github/workflows/e2e_tests_preview.yml Show resolved Hide resolved
src/app/submission-box/add-members/page.tsx Show resolved Hide resolved
src/app/submission-box/settings/page.tsx Show resolved Hide resolved
src/app/submission-box/settings/page.tsx Show resolved Hide resolved
@te-sa te-sa merged commit 61e6550 into master Nov 28, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ketphan02 ketphan02 ketphan02 approved these changes

@justino599 justino599 justino599 approved these changes

@Hedgemon4 Hedgemon4 Hedgemon4 approved these changes

@SecondFeline SecondFeline Awaiting requested review from SecondFeline

Assignees

@te-sa te-sa

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create form to create submission boxes
4 participants
@te-sa @ketphan02 @justino599 @Hedgemon4