공지사항 PresingedUrl 적용 #198

keemsebin · 2024-11-23T12:03:05Z

🔥 연관 이슈

close 공지사항 PresignedUrl 적용 #195

🚀 작업 내용

UploadMuitipleFile , UploadMuitipleImage 컴포넌트에서 기존 이미지, 추가된 이미지를 다룰 수 있도록 리팩토링 했습니다.
서버측 의견에 따라 기존에 단일 이미지를 다중이미지로 변경하였습니다.
fixzone 에 이상없는 지 확인했습니다.

🤔 고민했던 내용

통일성을 위해 기존에 다중 이미지 보여주는 방식을 참고하였습니다. presentIndex로 순서를 다루다 보니, 버튼을 여러번 누르게 되면 이미지를 순차적으로 로드하는 과정에 이미지 렌더링 시간이 누적되는 버그가 존재합니다. 추후 리팩토링이 필요해보입니다~!

vercel · 2024-11-23T12:03:10Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ddingdong-fe	❌ Failed (Inspect)			Jan 3, 2025 0:19am

coderabbitai · 2024-11-23T12:03:11Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

yougyung

작업량이 많네요.. 수고 많으셨습니다 👍
고양이 테스트이미지 덕분에 리뷰 도중웃음이 헤실헤실 ,, (∩ ͡° ͜ʖ ͡°)⊃━✿✿✿✿

어드민페이지에서는 노출이 잘 되는데, 일반페이지의 공지사항에서는 이미지가 잘리는 문제가 있네요! 확인 부탁드립니당

yougyung · 2025-01-03T07:01:27Z

src/components/common/UploadMultipleImage.tsx

ImagesController 컴포넌트가 정상적으로 기능하고 있지 않네요...!

해당 컴포넌트가 UX의 편의를 크게 높이지는 않는 것 같아서 수정보다는 컴포넌트의 삭제를 고려했는데, 아래 역할을 해주고 있어 일단 냅두고 마이그레이션 때 변경시키는 방향으로 고민하면 좋을 것 같아요 :)

수정 및 삭제 기능에는 문제가 없다는 점

해당 컴포넌트가 없다면 이미지가 있는 상태에서 이미지 추가가 불가능

엇 이미지 컨트롤러 확인을 못했었네요.
저도 컨트롤러 관련 부분 좋다고 생각합니다! 다만 직관성이 조금 떨어져서 실제로 버튼을 눌러보기 전까지는 해당 버튼을 통해 여러 이미지를 관리할 수 있다는 점을 잘 모를 것 같다는 생각이 들었어요.(사실 경험담입니다😅)
버튼을 눌렀을 경우 이미지가 슬라이드 형식으로 보이는 것도 좋지만, 조금 더 확장해서 실제 이미지 아래 배치해도 좋을 것 같다는 생각도 들었습니다! 또 x 버튼도 잘 보이지 않아 요런 부분 개선하면 좋을 것 같아요!
관련 디자인이 피그마에 없는 걸 보니 디자이너님이 모르시는 것 같아요! 요 부분은 다음주 스프린트때 이야기 하면 좋을 것 같은데 어떠신가요~!

넵 좋습니다 👍

5efecc8 수정했습니다~

yougyung · 2025-01-03T10:41:39Z

src/components/common/UploadMultipleFiles.tsx

-        setDocumentData((prev) => ({ ...prev, fileUrls: updatedFileUrls }));
-      }
-    }
+  function handleNewFileDelete(index: number) {


new file을 올리려다 삭제한 경우(설명이 어려워 동영상 첨부합니답,,), 반영되지 않아 보여요. onDelete함수가 실행되지않아 서버로 id값이 전달된 것 같습니다!

2025-01-03.7.39.57.mov

c80a593 수정했습니다~!

yougyung · 2025-01-03T11:00:08Z

src/components/common/UploadMultipleImage.tsx

-    ...existingFiles.map((item) => item.originUrl),
-    ...image.map((file) => URL.createObjectURL(file)),
-  ];
+  const allImages = useMemo(


useMemo로 불필요한 계산을 방지하셨네요 배워갑니다 👍

keemsebin added 13 commits November 23, 2024 03:11

refactor : 공지사항 hook type 변경

36be28e

fix : 공지사항 데이터 구조 변경 적용

bc4f8f3

fix : 동아리 목록 조회 profileImage 구조 변경 적용

1ea06eb

refactor : 공지사항 등록 presingedUrl 적용

bd144a5

fix : 자료실 파일 삭제 오류 수정

b5a04fb

fix : 공지사항 조회 type 수정

857c010

chore : console.log 삭제

94c2288

refactor : 공지사항 파일/이미지 수정 presingedUrl 적용

8a43b3e

fix : 공지사항 queryKey 수정, error 반환

c0437ad

feat : 공지사항 수정 multipleImage 미리보기 적용

a5d395f

fix : 복수 파일 수정을 위한 UploadMultipleFile 컴포넌트 수정

86bf8dd

fix : UploadMultipleImage 컴포넌트 handleImageDelete 함수 수정, allImages 배열 추가

dd74c93

style : presigedUrl 업로드 중 Btn disabled

4664106

keemsebin added the ⚛️ 프론트엔드 프론트엔드 관련 이슈 label Nov 23, 2024

keemsebin requested a review from yougyung November 23, 2024 12:03

keemsebin self-assigned this Nov 23, 2024

keemsebin marked this pull request as draft November 23, 2024 12:03

keemsebin added 2 commits January 3, 2025 18:56

fix : 이미지 useMemo 적용

bec7b12

fix : isUploading 변수 설정

ea54197

keemsebin marked this pull request as ready for review January 3, 2025 09:56

vercel bot had a problem deploying to Preview January 3, 2025 09:56 Failure

yougyung reviewed Jan 3, 2025

View reviewed changes

keemsebin added 3 commits January 3, 2025 20:34

fix : 일반 페이지 이미지 크기 변경

b25579b

fix : ImagesController props type 변경

5efecc8

fix : 파일 delete 수정

c80a593

vercel bot had a problem deploying to Preview January 3, 2025 12:19 Failure

yougyung approved these changes Jan 3, 2025

View reviewed changes

keemsebin merged commit eb595ac into staging Jan 3, 2025
2 of 3 checks passed

keemsebin deleted the refactor/DDING-20 branch January 3, 2025 14:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

공지사항 PresingedUrl 적용 #198

공지사항 PresingedUrl 적용 #198

keemsebin commented Nov 23, 2024 •

edited

Loading

vercel bot commented Nov 23, 2024 •

edited

Loading

coderabbitai bot commented Nov 23, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

yougyung left a comment

yougyung Jan 3, 2025

keemsebin Jan 3, 2025

yougyung Jan 3, 2025

keemsebin Jan 3, 2025

yougyung Jan 3, 2025

keemsebin Jan 3, 2025

yougyung Jan 3, 2025

공지사항 PresingedUrl 적용 #198

공지사항 PresingedUrl 적용 #198

Conversation

keemsebin commented Nov 23, 2024 • edited Loading

🔥 연관 이슈

🚀 작업 내용

🤔 고민했던 내용

vercel bot commented Nov 23, 2024 • edited Loading

coderabbitai bot commented Nov 23, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

yougyung left a comment

Choose a reason for hiding this comment

yougyung Jan 3, 2025

Choose a reason for hiding this comment

keemsebin Jan 3, 2025

Choose a reason for hiding this comment

yougyung Jan 3, 2025

Choose a reason for hiding this comment

keemsebin Jan 3, 2025

Choose a reason for hiding this comment

yougyung Jan 3, 2025

Choose a reason for hiding this comment

keemsebin Jan 3, 2025

Choose a reason for hiding this comment

yougyung Jan 3, 2025

Choose a reason for hiding this comment

keemsebin commented Nov 23, 2024 •

edited

Loading

vercel bot commented Nov 23, 2024 •

edited

Loading

coderabbitai bot commented Nov 23, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)