Feedback #1
Open
Feedback #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-classroom[bot]](https://avatars.githubusercontent.com/in/68187?s=60&v=4){kind=small}
…ginal fxml file because made changes to mainScene
# Conflicts: # src/main/resources/mainScene.fxml
# Conflicts: # src/main/resources/mainScene.fxml
# Conflicts: # src/main/resources/mainScene.fxml
# Conflicts: # src/main/java/cs3500/pa05/controller/BujoController.java # src/main/resources/mainScene2.fxml # src/main/resources/noteScene.fxml # src/main/resources/openFileScene.fxml # src/main/resources/quoteScene.fxml # src/main/resources/saveFileScene.fxml
Added some tests for the Day, Event, Task, Time and Week class
features.md push
REDAME.txt
Section 1: Requirements
Section 2: Headlining Features
Section 3: Power Ups
Section 4: Quality of Life(+0) Section 5: Extra Credit(+0) (All group members present for demo) |
There was a problem hiding this comment.
Feedback: PA05
My overall feedback on your PA05 submission is below. Please review all feedback thoroughly.
Section 1: Initial Design (20pts)
- Grade: 20 / 20
- Comments: Please refer to comments previously provided by your Pod TA.
—
Section 2: Alpha Release (10pts)
- Grade: 10 / 10
Section 3: Implementation Correctness (34pts)
- Grade: 20 / 34
- Comments: See earlier review for feedback
Section 4: Implementation Design Quality (20pts)
- Grade: 20 / 20
- Comments: Great work!
Section 5: Code Quality (6pts)
- Grade: 6 / 6
- Comments: Great work!
Section 5: Test Quality (10pts)
- Grade: 10 / 10
- Comments: Great work!
Extra Credit (+≤38pts)
- Grade: +0
- Comments: See earlier review for feedback
Overall (100pts)
- Grade: 86 / 100
- Comments: Overall, a very nice job!
For additional feedback, please review the comments provided in this Pull Request review under “Conversation.”
See Piazza for additional information if you believe something was graded incorrectly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mainsince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips:
mainsince the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.main. Click a commit to see specific changes.For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @carolinetpham @marbleville @p27sinha