Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Contact Info, Update App Icon + Accent Color #3

Merged
merged 5 commits into from
Jan 22, 2024

Conversation

bryant-jimenez
Copy link
Contributor

Update Contact Info + App Icon

♻️ Current situation & Problem

  • The application required an app icon update, accent color update to align with app icon color scheme, and contact information update for the project contacts.

⚙️ Release Notes

  • No new features added, only visual changes. Contact view information for three main contacts changed to only allow for email contact and website viewing.

📚 Documentation

  • No need to update documentation, only smaller visual changes

✅ Testing

  • Updated text within prior working version of app, visual changes

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@bryant-jimenez bryant-jimenez self-assigned this Jan 14, 2024
@bryant-jimenez bryant-jimenez added the enhancement New feature or request label Jan 14, 2024
Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (1d168bf) 38.12% compared to head (b092582) 39.35%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
+ Coverage   38.12%   39.35%   +1.24%     
==========================================
  Files          31       31              
  Lines         976     1009      +33     
==========================================
+ Hits          372      397      +25     
- Misses        604      612       +8     
Files Coverage Δ
Behavior/Contacts/Contacts.swift 71.96% <82.36%> (+2.57%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d168bf...b092582. Read the comment docs.

Copy link

@aydinzahedi aydinzahedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Especially appreciated that you used the PR template well to document, and great job using the string catalog for the bios.

@philippzagar
Copy link

@bryant-jimenez Please make the changes and then request a review again! :)

@philippzagar philippzagar removed their request for review January 22, 2024 21:53
fixed stale extraction state
@bryant-jimenez bryant-jimenez merged commit eca33c2 into main Jan 22, 2024
7 checks passed
@bryant-jimenez bryant-jimenez deleted the feature/task1-adjust-contacts branch January 22, 2024 22:16
@bryant-jimenez bryant-jimenez changed the title feature/task1-adjust-contacts Adjust Contact Info, Update App Icon + Accent Color Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants