Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/fixadd #44

Merged
merged 7 commits into from
Mar 14, 2024
Merged

Features/fixadd #44

merged 7 commits into from
Mar 14, 2024

Conversation

dhruvna1k
Copy link
Contributor

@dhruvna1k dhruvna1k commented Mar 13, 2024

*Fixing add function to make pull request

♻️ Current situation & Problem

I was using an @dependency incorrectly and needed to use it within the add function of the Prisma Standard allow the program to run properly and the toggle states can be accessed within the Standard now for omitting data writing to Firestore.

⚙️ Release Notes

Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 35.08%. Comparing base (9c38895) to head (e810961).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   35.26%   35.08%   -0.17%     
==========================================
  Files          44       44              
  Lines        2031     2007      -24     
==========================================
- Hits          716      704      -12     
+ Misses       1315     1303      -12     
Files Coverage Δ
Prisma/PrivacyControls/PrivacyModule.swift 96.30% <100.00%> (+1.79%) ⬆️
Prisma/Standard/PrismaStandard.swift 6.22% <ø> (ø)
Prisma/Standard/PrismaStandard+HealthKit.swift 4.55% <0.00%> (+0.51%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c38895...e810961. Read the comment docs.

@dhruvna1k dhruvna1k merged commit f5d870e into main Mar 14, 2024
7 checks passed
@dhruvna1k dhruvna1k deleted the features/fixadd branch March 14, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants