Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Cleanup & Restructure Code #49

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Code Cleanup & Restructure Code #49

merged 3 commits into from
Mar 18, 2024

Conversation

PSchmiedmayer
Copy link
Member

Code Cleanup & Restructure Code

⚙️ Release Notes

  • Restructures the code into smaller views & improves testability and SwiftUI previews.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@PSchmiedmayer PSchmiedmayer added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Mar 18, 2024
@PSchmiedmayer PSchmiedmayer self-assigned this Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 7.27273% with 663 lines in your changes are missing coverage. Please review.

Project coverage is 26.58%. Comparing base (87a986f) to head (be9d8f3).

❗ Current head be9d8f3 differs from pull request most recent head d5fd39f. Consider uploading reports for the commit d5fd39f to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   36.24%   26.58%   -9.66%     
==========================================
  Files          44       53       +9     
  Lines        2045     1942     -103     
==========================================
- Hits          741      516     -225     
- Misses       1304     1426     +122     
Files Coverage Δ
Prisma/Chat/WebView.swift 0.00% <ø> (ø)
Prisma/Helper/Date+ISOFormat.swift 0.00% <ø> (ø)
Prisma/Home.swift 89.75% <100.00%> (+28.81%) ⬆️
Prisma/Onboarding/NotificationPermissions.swift 2.23% <ø> (ø)
Prisma/Onboarding/OnboardingFlow.swift 95.66% <ø> (-0.34%) ⬇️
Prisma/Onboarding/Welcome.swift 96.08% <100.00%> (ø)
Prisma/PrismaDelegate.swift 96.50% <100.00%> (-0.02%) ⬇️
...risma/PrivacyControls/HKSampleType+Encodable.swift 100.00% <100.00%> (ø)
Prisma/PrivacyControls/HKSampleTypeDecodable.swift 100.00% <100.00%> (ø)
Prisma/Standard/PrismaStandard+Questionnaire.swift 0.00% <ø> (ø)
... and 21 more

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87a986f...d5fd39f. Read the comment docs.

@PSchmiedmayer PSchmiedmayer merged commit 18e0bc8 into main Mar 18, 2024
5 checks passed
@PSchmiedmayer PSchmiedmayer deleted the cleanup branch March 18, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant